diff options
| author | Christian Brabandt <cb@256bit.org> | 2023-09-15 20:22:02 +0200 |
|---|---|---|
| committer | Christian Brabandt <cb@256bit.org> | 2023-09-15 20:22:02 +0200 |
| commit | ffb13674d1af1c90beb229867ec989e4fb232df3 (patch) | |
| tree | 6309506286c8b90dc12c7f13e067a96b1e21b626 | |
| parent | c30a90d9b2c029f794cea502f6b824f71e4876dd (diff) | |
patch 9.0.1899: potential buffer overflow in PBYTE macrov9.0.1899
Problem: potential buffer overflow in PBYTE macro
Solution: Check returned memline length
closes: #13083
the PBYTE macro is used to put byte c at a position lp of the returned
memline. However, in case of unexpected errors ml_get_buf() may return
either "???" or an empty line in which case it is quite likely that we
are causing a buffer overrun.
Therefore, switch the macro PBYTE (which is only used in ops.c anyhow)
to a function, that verifies that we will only try to access within the
given length of the buffer.
Also, since the macro is only used in ops.c, move the definition from
macros.h to ops.c
Signed-off-by: Christian Brabandt <cb@256bit.org>
| -rw-r--r-- | src/macros.h | 5 | ||||
| -rw-r--r-- | src/ops.c | 18 | ||||
| -rw-r--r-- | src/version.c | 2 |
3 files changed, 20 insertions, 5 deletions
diff --git a/src/macros.h b/src/macros.h index d86097ced3..cc2d11fdd1 100644 --- a/src/macros.h +++ b/src/macros.h @@ -14,11 +14,6 @@ */ /* - * PBYTE(lp, c) - put byte 'c' at position 'lp' - */ -#define PBYTE(lp, c) (*(ml_get_buf(curbuf, (lp).lnum, TRUE) + (lp).col) = (c)) - -/* * Position comparisons */ #define LT_POS(a, b) (((a).lnum != (b).lnum) \ @@ -17,6 +17,9 @@ static void shift_block(oparg_T *oap, int amount); static void mb_adjust_opend(oparg_T *oap); static int do_addsub(int op_type, pos_T *pos, int length, linenr_T Prenum1); +static void pbyte(pos_T lp, int c); +#define PBYTE(lp, c) pbyte(lp, c) + // Flags for third item in "opchars". #define OPF_LINES 1 // operator always works on lines @@ -4349,3 +4352,18 @@ do_pending_operator(cmdarg_T *cap, int old_col, int gui_yank) restore_lbr(lbr_saved); #endif } + +// put byte 'c' at position 'lp', but +// verify, that the position to place +// is actually safe + static void +pbyte(pos_T lp, int c) +{ + char_u *p = ml_get_buf(curbuf, lp.lnum, TRUE); + int len = curbuf->b_ml.ml_line_len; + + // safety check + if (lp.col >= len) + lp.col = (len > 1 ? len - 2 : 0); + *(p + lp.col) = c; +} diff --git a/src/version.c b/src/version.c index ba4be27807..4576d5a4c2 100644 --- a/src/version.c +++ b/src/version.c @@ -700,6 +700,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1899, +/**/ 1898, /**/ 1897, |