diff options
author | zeertzjq <zeertzjq@outlook.com> | 2022-02-02 13:16:37 +0000 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2022-02-02 13:16:37 +0000 |
commit | 73257149d759a8e6ddbe555d2b5aa37b6cb8db8b (patch) | |
tree | f4dc51a7a5969f822e1f2d151441125c10efd3d0 | |
parent | adbb1bf21dad5697cd82d46d9dd9e8e8d0f647e6 (diff) |
patch 8.2.4283: using a variable for the return value is not neededv8.2.4283
Problem: Using a variable for the return value is not needed.
Solution: Return the value directly. (closes #9687)
-rw-r--r-- | src/ex_docmd.c | 47 | ||||
-rw-r--r-- | src/misc2.c | 16 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 30 insertions, 35 deletions
diff --git a/src/ex_docmd.c b/src/ex_docmd.c index 64dcd7e2bf..d8adf85bcb 100644 --- a/src/ex_docmd.c +++ b/src/ex_docmd.c @@ -7358,7 +7358,8 @@ changedir_func( { char_u *pdir = NULL; int dir_differs; - int retval = FALSE; + char_u *acmd_fname; + char_u **pp; if (new_dir == NULL || allbuf_locked()) return FALSE; @@ -7415,38 +7416,32 @@ changedir_func( { emsg(_(e_command_failed)); vim_free(pdir); + return FALSE; } + + if (scope == CDSCOPE_WINDOW) + pp = &curwin->w_prevdir; + else if (scope == CDSCOPE_TABPAGE) + pp = &curtab->tp_prevdir; else - { - char_u *acmd_fname; - char_u **pp; + pp = &prev_dir; + vim_free(*pp); + *pp = pdir; + + post_chdir(scope); + if (dir_differs) + { if (scope == CDSCOPE_WINDOW) - pp = &curwin->w_prevdir; + acmd_fname = (char_u *)"window"; else if (scope == CDSCOPE_TABPAGE) - pp = &curtab->tp_prevdir; + acmd_fname = (char_u *)"tabpage"; else - pp = &prev_dir; - vim_free(*pp); - *pp = pdir; - - post_chdir(scope); - - if (dir_differs) - { - if (scope == CDSCOPE_WINDOW) - acmd_fname = (char_u *)"window"; - else if (scope == CDSCOPE_TABPAGE) - acmd_fname = (char_u *)"tabpage"; - else - acmd_fname = (char_u *)"global"; - apply_autocmds(EVENT_DIRCHANGED, acmd_fname, new_dir, FALSE, - curbuf); - } - retval = TRUE; + acmd_fname = (char_u *)"global"; + apply_autocmds(EVENT_DIRCHANGED, acmd_fname, new_dir, FALSE, + curbuf); } - - return retval; + return TRUE; } /* diff --git a/src/misc2.c b/src/misc2.c index b6d5e066c6..fac836fb76 100644 --- a/src/misc2.c +++ b/src/misc2.c @@ -1903,7 +1903,6 @@ vim_chdirfile(char_u *fname, char *trigger_autocmd) { char_u old_dir[MAXPATHL]; char_u new_dir[MAXPATHL]; - int res; if (mch_dirname(old_dir, MAXPATHL) != OK) *old_dir = NUL; @@ -1913,16 +1912,15 @@ vim_chdirfile(char_u *fname, char *trigger_autocmd) if (pathcmp((char *)old_dir, (char *)new_dir, -1) == 0) // nothing to do - res = OK; - else - { - res = mch_chdir((char *)new_dir) == 0 ? OK : FAIL; + return OK; + + if (mch_chdir((char *)new_dir) != 0) + return FAIL; - if (res == OK && trigger_autocmd != NULL) - apply_autocmds(EVENT_DIRCHANGED, (char_u *)trigger_autocmd, + if (trigger_autocmd != NULL) + apply_autocmds(EVENT_DIRCHANGED, (char_u *)trigger_autocmd, new_dir, FALSE, curbuf); - } - return res; + return OK; } #endif diff --git a/src/version.c b/src/version.c index b96637f152..f1014b3fe6 100644 --- a/src/version.c +++ b/src/version.c @@ -747,6 +747,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 4283, +/**/ 4282, /**/ 4281, |