Make sure 'become' process is given a proper tty device

2 files changed, 13 insertions, 0 deletions

diff --git a/src/terminal.go b/src/terminal.go
index f25cd2f3..7f6adade 100644
--- a/src/terminal.go
+++ b/src/terminal.go
@@ -2961,6 +2961,14 @@ func (t *Terminal) Loop() {
 						if t.history != nil {
 							t.history.append(string(t.input))
 						}
+						/*
+							FIXME: It is not at all clear why this is required.
+							The following command will report 'not a tty', unless we open
+							/dev/tty *twice* after closing the standard input for 'reload'
+							in Reader.terminate().
+								: | fzf --bind 'start:reload:ls' --bind 'enter:become:tty'
+						*/
+						tui.TtyIn()
 						util.SetStdin(tui.TtyIn())
 						syscall.Exec(shellPath, []string{shell, "-c", command}, os.Environ())
 					}
diff --git a/test/test_go.rb b/test/test_go.rb
index 1f4245ab..f7dcfe6e 100755
--- a/test/test_go.rb
+++ b/test/test_go.rb
@@ -2921,6 +2921,11 @@ class TestGoFZF < TestBase
     OUTPUT
     tmux.until { assert_block(expected, _1) }
   end
+
+  def test_become_tty
+    tmux.send_keys "sleep 0.5 | #{FZF} --bind 'start:reload:ls' --bind 'load:become:tty'", :Enter
+    tmux.until { |lines| assert_includes lines, '/dev/tty' }
+  end
 end
 
 module TestShell