summaryrefslogtreecommitdiffstats
path: root/src/json.c
diff options
context:
space:
mode:
authorBram Moolenaar <Bram@vim.org>2017-01-22 15:56:26 +0100
committerBram Moolenaar <Bram@vim.org>2017-01-22 15:56:26 +0100
commite2c6037da387aad05e4f6bd4a8a6267051d6de04 (patch)
treec138bdfbc103396f0995c142e23ce475a05b4be4 /src/json.c
parente362c3d2c34f2b7ff38b4c3d2a7ff127d2290e09 (diff)
patch 8.0.0216: decoding js style json may failv8.0.0216
Problem: When decoding JSON with a JS style object the JSON test may use a NULL pointer. (Coverity) Solution: Check for a NULL pointer.
Diffstat (limited to 'src/json.c')
-rw-r--r--src/json.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/src/json.c b/src/json.c
index a9333cf076..fd1b6ec3db 100644
--- a/src/json.c
+++ b/src/json.c
@@ -629,10 +629,13 @@ json_decode_item(js_read_T *reader, typval_T *res, int options)
key = p = reader->js_buf + reader->js_used;
while (*p != NUL && *p != ':' && *p > ' ')
++p;
- cur_item->v_type = VAR_STRING;
- cur_item->vval.v_string = vim_strnsave(key, (int)(p - key));
+ if (cur_item != NULL)
+ {
+ cur_item->v_type = VAR_STRING;
+ cur_item->vval.v_string = vim_strnsave(key, (int)(p - key));
+ top_item->jd_key = cur_item->vval.v_string;
+ }
reader->js_used += (int)(p - key);
- top_item->jd_key = cur_item->vval.v_string;
}
else
{
@@ -1053,7 +1056,8 @@ json_decode(js_read_T *reader, typval_T *res, int options)
/*
* Decode the JSON from "reader" to find the end of the message.
- * "options" can be JSON_JS or zero;
+ * "options" can be JSON_JS or zero.
+ * This is only used for testing.
* Return FAIL if the message has a decoding error.
* Return MAYBE if the message is truncated, need to read more.
* This only works reliable if the message contains an object, array or