summaryrefslogtreecommitdiffstats
path: root/job.c
diff options
context:
space:
mode:
authornicm <nicm>2021-02-19 09:09:16 +0000
committernicm <nicm>2021-02-19 09:09:16 +0000
commitb04f8acb7057bda74e30976acedbbd73767e5bdc (patch)
tree8b3be4d6a36b2dcc2fb668a510f94f4d3a1ec1d0 /job.c
parentfb42ae3071763fdc6a2fe2e57feec774623b1c33 (diff)
Check return value of chdir() to stop a silly warning with some
compilers, GitHub issue 2573.
Diffstat (limited to 'job.c')
-rw-r--r--job.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/job.c b/job.c
index efc0199e..6267336b 100644
--- a/job.c
+++ b/job.c
@@ -114,10 +114,10 @@ job_run(const char *cmd, struct session *s, const char *cwd,
proc_clear_signals(server_proc, 1);
sigprocmask(SIG_SETMASK, &oldset, NULL);
- if (cwd == NULL || chdir(cwd) != 0) {
- if ((home = find_home()) == NULL || chdir(home) != 0)
- chdir("/");
- }
+ if ((cwd == NULL || chdir(cwd) != 0) &&
+ ((home = find_home()) == NULL || chdir(home) != 0) &&
+ chdir("/") != 0)
+ fatal("chdir failed");
environ_push(env);
environ_free(env);