summaryrefslogtreecommitdiffstats
path: root/cmd-run-shell.c
diff options
context:
space:
mode:
authorNicholas Marriott <nicm@openbsd.org>2012-07-11 07:10:15 +0000
committerNicholas Marriott <nicm@openbsd.org>2012-07-11 07:10:15 +0000
commitede8312d59c5d08990f83f38682c26434823525b (patch)
treebdf66e80ca1d71548a554804f4ab6656a828a821 /cmd-run-shell.c
parentdf912e3540968a2a0b266e523ecc08bb2dc0ca20 (diff)
Make command exec functions return an enum rather than -1/0/1 values and
add a new value to mean "leave client running but don't attach" to fix problems with using some commands in a command sequence. Most of the work by Thomas Adam, problem reported by "jspenguin" on SF bug 3535531.
Diffstat (limited to 'cmd-run-shell.c')
-rw-r--r--cmd-run-shell.c11
1 files changed, 5 insertions, 6 deletions
diff --git a/cmd-run-shell.c b/cmd-run-shell.c
index 6a80d4ef..dcbcb375 100644
--- a/cmd-run-shell.c
+++ b/cmd-run-shell.c
@@ -29,10 +29,9 @@
* Runs a command without a window.
*/
-int cmd_run_shell_exec(struct cmd *, struct cmd_ctx *);
-
-void cmd_run_shell_callback(struct job *);
-void cmd_run_shell_free(void *);
+enum cmd_retval cmd_run_shell_exec(struct cmd *, struct cmd_ctx *);
+void cmd_run_shell_callback(struct job *);
+void cmd_run_shell_free(void *);
const struct cmd_entry cmd_run_shell_entry = {
"run-shell", "run",
@@ -49,7 +48,7 @@ struct cmd_run_shell_data {
struct cmd_ctx ctx;
};
-int
+enum cmd_retval
cmd_run_shell_exec(struct cmd *self, struct cmd_ctx *ctx)
{
struct args *args = self->args;
@@ -67,7 +66,7 @@ cmd_run_shell_exec(struct cmd *self, struct cmd_ctx *ctx)
job_run(shellcmd, cmd_run_shell_callback, cmd_run_shell_free, cdata);
- return (1); /* don't let client exit */
+ return (CMD_RETURN_YIELD); /* don't let client exit */
}
void