summaryrefslogtreecommitdiffstats
path: root/client.c
diff options
context:
space:
mode:
authornicm <nicm>2020-10-30 18:54:23 +0000
committernicm <nicm>2020-10-30 18:54:23 +0000
commit95841ba16acafa8c1a516712ad0f2b48e34357e6 (patch)
tree6bf01605a4b1f6c4e97ed17ca8fea84d5580ca84 /client.c
parent9726c4454e29cb5b9c6681abfb5c99972a9bd574 (diff)
With csh, a tmux client gets SIGTERM before SIGCONT when killed with
"kill %%", so when the client tells the server it got SIGCONT, don't use bits that may already have been freed when it got SIGTERM. Also don't print anything on exit if we get SIGTERM while suspended. Reported by Theo.
Diffstat (limited to 'client.c')
-rw-r--r--client.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/client.c b/client.c
index f08d6f29..dcbc0d18 100644
--- a/client.c
+++ b/client.c
@@ -36,6 +36,7 @@
static struct tmuxproc *client_proc;
static struct tmuxpeer *client_peer;
static uint64_t client_flags;
+static int client_suspended;
static enum {
CLIENT_EXIT_NONE,
CLIENT_EXIT_DETACHED,
@@ -221,7 +222,7 @@ static void
client_exit(void)
{
struct client_file *cf;
- size_t left;
+ size_t left;
int waiting = 0;
RB_FOREACH (cf, client_files, &client_files) {
@@ -763,6 +764,7 @@ client_signal(int sig)
struct sigaction sigact;
int status;
+ log_debug("%s: %s", __func__, strsignal(sig));
if (sig == SIGCHLD)
waitpid(WAIT_ANY, &status, WNOHANG);
else if (!client_attached) {
@@ -776,7 +778,8 @@ client_signal(int sig)
proc_send(client_peer, MSG_EXITING, -1, NULL, 0);
break;
case SIGTERM:
- client_exitreason = CLIENT_EXIT_TERMINATED;
+ if (!client_suspended)
+ client_exitreason = CLIENT_EXIT_TERMINATED;
client_exitval = 1;
proc_send(client_peer, MSG_EXITING, -1, NULL, 0);
break;
@@ -791,6 +794,7 @@ client_signal(int sig)
if (sigaction(SIGTSTP, &sigact, NULL) != 0)
fatal("sigaction failed");
proc_send(client_peer, MSG_WAKEUP, -1, NULL, 0);
+ client_suspended = 0;
break;
}
}
@@ -1003,6 +1007,7 @@ client_dispatch_attached(struct imsg *imsg)
sigact.sa_handler = SIG_DFL;
if (sigaction(SIGTSTP, &sigact, NULL) != 0)
fatal("sigaction failed");
+ client_suspended = 1;
kill(getpid(), SIGTSTP);
break;
case MSG_LOCK: