summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAndrew Gallant <jamslam@gmail.com>2023-09-28 16:25:35 -0400
committerAndrew Gallant <jamslam@gmail.com>2023-09-28 16:57:06 -0400
commit70b093647ed11842f86db04a95497be7b3d8a798 (patch)
tree8fe81403677f13c429f17506e1a374beed496985
parent13e77886093d698b83421c064bdd9839ac13e4f3 (diff)
printer: remove 'subl' aliasag/polish
It was apparently using a format specific to a particular plugin. I did know that, but apparently the plugin is not ubiquitous or de facto standard[1]. Thus, including it I think just leads to more confusion. We definitely do not want to be in the business of bundling aliases for every conceivable plugin to different editors, so just drop it. We expose the ability to write your own format for exactly this sort of reason. [1]: https://github.com/BurntSushi/ripgrep/discussions/2611#discussioncomment-7138302
-rw-r--r--crates/core/app.rs8
-rw-r--r--crates/printer/src/hyperlink_aliases.rs2
2 files changed, 4 insertions, 6 deletions
diff --git a/crates/core/app.rs b/crates/core/app.rs
index ae97a2b5..f78ed8dd 100644
--- a/crates/core/app.rs
+++ b/crates/core/app.rs
@@ -1529,10 +1529,10 @@ in terminal emulators that support OSC-8 hyperlinks. For example, the format
file://{host}{path} will emit an RFC 8089 hyperlink. To see the format that
ripgrep is using, pass the --debug flag.
-Alternatively, a format string may correspond to one of the following
-aliases: default, file, grep+, kitty, macvim, none, subl, textmate, vscode,
-vscode-insiders, vscodium. The alias will be replaced with a format string that
-is intended to work for the corresponding application.
+Alternatively, a format string may correspond to one of the following aliases:
+default, file, grep+, kitty, macvim, none, textmate, vscode, vscode-insiders,
+vscodium. The alias will be replaced with a format string that is intended to
+work for the corresponding application.
The following variables are available in the format string:
diff --git a/crates/printer/src/hyperlink_aliases.rs b/crates/printer/src/hyperlink_aliases.rs
index c98bc0b0..9bad1b86 100644
--- a/crates/printer/src/hyperlink_aliases.rs
+++ b/crates/printer/src/hyperlink_aliases.rs
@@ -13,8 +13,6 @@ const HYPERLINK_PATTERN_ALIASES: &[(&str, &str)] = &[
// https://macvim.org/docs/gui_mac.txt.html#mvim%3A%2F%2F
("macvim", "mvim://open?url=file://{path}&line={line}&column={column}"),
("none", ""),
- // https://github.com/inopinatus/sublime_url
- ("subl", "subl://open?url=file://{path}&line={line}&column={column}"),
// https://macromates.com/blog/2007/the-textmate-url-scheme/
("textmate", "txmt://open?url=file://{path}&line={line}&column={column}"),
// https://code.visualstudio.com/docs/editor/command-line#_opening-vs-code-with-urls