diff options
| author | Reinhard Urban <reinhard.urban@nubix.de> | 2022-10-28 09:56:05 +0200 |
|---|---|---|
| committer | Tomas Mraz <tomas@openssl.org> | 2022-11-07 19:22:57 +0100 |
| commit | 6feff2e59dfd1ac1dffa77b0baa53c7e09d50029 (patch) | |
| tree | 4f3941c0af4eea4b96023b926cf6a9fdf287268f /test | |
| parent | f3aa51d63473f2b735cf3c01741ad418fc600e08 (diff) | |
Fix PACKET_equal test with BUF_LEN+1 on -Wstringop-overread
Either suppress the error, or better make smbuf longer.
Detected with -Werror.
CLA: trivial
Reviewed-by: Hugo Landau <hlandau@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/19528)
(cherry picked from commit 91b7520e2385a513ad879dfa8fe8e45466315a27)
Diffstat (limited to 'test')
| -rw-r--r-- | test/packettest.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/test/packettest.c b/test/packettest.c index b82b9fb502..17831d940b 100644 --- a/test/packettest.c +++ b/test/packettest.c @@ -12,13 +12,13 @@ #define BUF_LEN 255 -static unsigned char smbuf[BUF_LEN]; +static unsigned char smbuf[BUF_LEN + 1]; static int test_PACKET_remaining(void) { PACKET pkt; - if (!TEST_true(PACKET_buf_init(&pkt, smbuf, sizeof(smbuf))) + if (!TEST_true(PACKET_buf_init(&pkt, smbuf, BUF_LEN)) || !TEST_size_t_eq(PACKET_remaining(&pkt), BUF_LEN) || !TEST_true(PACKET_forward(&pkt, BUF_LEN - 1)) || !TEST_size_t_eq(PACKET_remaining(&pkt), 1) @@ -33,7 +33,7 @@ static int test_PACKET_end(void) { PACKET pkt; - if (!TEST_true(PACKET_buf_init(&pkt, smbuf, sizeof(smbuf))) + if (!TEST_true(PACKET_buf_init(&pkt, smbuf, BUF_LEN)) || !TEST_size_t_eq(PACKET_remaining(&pkt), BUF_LEN) || !TEST_ptr_eq(PACKET_end(&pkt), smbuf + BUF_LEN) || !TEST_true(PACKET_forward(&pkt, BUF_LEN - 1)) |