From 6feff2e59dfd1ac1dffa77b0baa53c7e09d50029 Mon Sep 17 00:00:00 2001 From: Reinhard Urban Date: Fri, 28 Oct 2022 09:56:05 +0200 Subject: Fix PACKET_equal test with BUF_LEN+1 on -Wstringop-overread Either suppress the error, or better make smbuf longer. Detected with -Werror. CLA: trivial Reviewed-by: Hugo Landau Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/19528) (cherry picked from commit 91b7520e2385a513ad879dfa8fe8e45466315a27) --- test/packettest.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/packettest.c b/test/packettest.c index b82b9fb502..17831d940b 100644 --- a/test/packettest.c +++ b/test/packettest.c @@ -12,13 +12,13 @@ #define BUF_LEN 255 -static unsigned char smbuf[BUF_LEN]; +static unsigned char smbuf[BUF_LEN + 1]; static int test_PACKET_remaining(void) { PACKET pkt; - if (!TEST_true(PACKET_buf_init(&pkt, smbuf, sizeof(smbuf))) + if (!TEST_true(PACKET_buf_init(&pkt, smbuf, BUF_LEN)) || !TEST_size_t_eq(PACKET_remaining(&pkt), BUF_LEN) || !TEST_true(PACKET_forward(&pkt, BUF_LEN - 1)) || !TEST_size_t_eq(PACKET_remaining(&pkt), 1) @@ -33,7 +33,7 @@ static int test_PACKET_end(void) { PACKET pkt; - if (!TEST_true(PACKET_buf_init(&pkt, smbuf, sizeof(smbuf))) + if (!TEST_true(PACKET_buf_init(&pkt, smbuf, BUF_LEN)) || !TEST_size_t_eq(PACKET_remaining(&pkt), BUF_LEN) || !TEST_ptr_eq(PACKET_end(&pkt), smbuf + BUF_LEN) || !TEST_true(PACKET_forward(&pkt, BUF_LEN - 1)) -- cgit v1.2.3