diff options
| author | Joerg <JoergAtGithub@worldwartweb.com> | 2023-06-02 00:17:46 +0200 |
|---|---|---|
| committer | Joerg <JoergAtGithub@worldwartweb.com> | 2023-06-02 00:17:46 +0200 |
| commit | a0995cc4bb11b8f2c6d2ceec6c0de4f63ae2f79a (patch) | |
| tree | 07fb27e5a6be2dfbea179412e6a7097eff4fb16e | |
| parent | 749e0fd2e0c94aa996fb379959eb9063284821a8 (diff) | |
Use existing WARNINGS_FATAL and set it in .github/workflow/build.yml
| -rw-r--r-- | .github/workflows/build.yml | 1 | ||||
| -rw-r--r-- | CMakeLists.txt | 4 |
2 files changed, 3 insertions, 2 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e4eb607aa8..66c5f07efa 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -109,6 +109,7 @@ jobs: # also adjust the for the local Windows build setup in # ./tools/windows_buildenv.bat cmake_args: >- + -DWARNINGS_FATAL=ON -DBULK=OFF -DFFMPEG=OFF -DHSS1394=ON diff --git a/CMakeLists.txt b/CMakeLists.txt index 246f003ba7..4be9ec8187 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1293,8 +1293,8 @@ if(MSVC) if(WARNINGS_PEDANTIC) target_compile_options(mixxx-lib PUBLIC /W4) else() - # Warning Level 3 (production quality) / Treat Warnings as Errors - target_compile_options(mixxx-lib PUBLIC /W3 /WX) + # Warning Level 3 (production quality) + target_compile_options(mixxx-lib PUBLIC /W3) target_compile_definitions(mixxx-lib PUBLIC _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING _CRT_SECURE_NO_WARNINGS) endif() else() |