| Age | Commit message (Collapse) | Author |
|---|
|
Problem: Window may unexpectedly scroll when 'scrollbind' is set
and setting a buffer-local option using setbufvar()
(Boris Staletic)
Solution: Save and restore the windows topline before opening the
popup window.
fixes: #13863
closes: #13869
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: Maximum callback depth is not configurable.
Solution: Revert patch 9.0.2103. Set 'maxfuncdepth' in test.
(zeertzjq)
fixes: #13732
closes: #13736
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: Cannot accurately get mouse clicking position when clicking on
a TAB or with virtual text.
Solution: Add a "coladd" field to getmousepos() result.
closes: #13335
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: zeertzjq <zeertzjq@outlook.com>
|
|
Problem: no max callback recursion limit
Solution: bail out, if max call recursion for callback functions
has been reached.
This checks the 'maxfuncdepth' setting and throws E169 when a callback
function recursively calls itself.
closes: #13337
closes: #13339
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: Cannot wrap around in popup_filter_menu()
Solution: Allow to wrap around by default
Currently, it is not possible, to wrap around at the end of the list
using e.g. down (and go back to the top) or up at the beginning of the
list and go directly to the last item. This is not consistent behaviour
with e.g. how the pum-menu currently works, so let's just allow this.
Also adjust tests about it.
closes: #12689
closes: #12693
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: popup_create() not aborting on errors
Solution: check for errors in arguments given and abort if an error
occurred
closes: #12711
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: Code style test fails.
Solution: Adjust test files.
|
|
Problem: Popupwin test is more flaky on MacOS.
Solution: Use a longer wait time.
|
|
Problem: Terminal tests fail when using key with modifier.
Solution: Use the modifyOtherKeys encoding when using RunVimInTerminal().
|
|
Problem: Various typos.
Solution: Correct typos. (closes #11432)
|
|
Problem: Popup menu highlight wrong on top of preview popup. (Yegappan
Lakshmanan)
Solution: Also check for the popup menu in screen_line().
|
|
Problem: Too many delete() calls in tests.
Solution: Use deferred delete where possible.
|
|
Problem: ml_get error when appending lines in popup window.
Solution: Only update w_topline when w_buffer matches curbuf.
(closes #11074)
|
|
Problem: Common names in test files causes tests to be flaky.
Solution: Use more specific names.
|
|
Problem: Checks for Dictionary argument often give a vague error message.
Solution: Give a useful error message. (Yegappan Lakshmanan, closes #11009)
|
|
Problem: Can escape a terminal popup window when the job is finished.
Solution: Only check for a finished job where it is relevant.
(closes #10253)
|
|
Problem: Scrollbar thumb in tall scrolled popup not visible.
Solution: Show at least one thumb character. (fixes 10492)
|
|
Problem: Cannot close a terminal popup with "NONE" job.
Solution: Adjust the conditions for whether a job is running.
(closes #10498)
|
|
Problem: Scrollbar thumb in scrolled popup not visible.
Solution: Show at least one thumb character. (fixes 10492)
|
|
Problem: Confusing error if first argument of popup_create() is wrong.
Solution: Give a more informative error.
|
|
Problem: A finished terminal in a popup window does not show a scrollbar.
Solution: Show the scrollbar if the terminal job is finished. (closes
#10497)
|
|
Problem: Popup_hide() does not always have effect.
Solution: Add the POPF_HIDDEN_FORCE flag. (closes #10376)
|
|
Problem: Popup does not use correct topline.
Solution: Also add one when firstline is negative. (closes #10229)
|
|
Problem: When a swap file is found for a popup there is no dialog and the
buffer is loaded anyway.
Solution: Silently load the buffer read-only. (closes #10073)
|
|
Problem: Popup with "minwidth" and scrollbar not updated properly.
Solution: Adjust the computation if the window width. (closes #10061)
|
|
Problem: Vim9: can still use a global function without g: at the script
level.
Solution: Also check for g: at the script level. (issue #9637)
|
|
Problem: Vim9: finding global function without g: prefix but not finding
global variable is inconsistent.
Solution: Require using g: for a global function. Change the vim9.vim
script into a Vim9 script with exports. Fix that import in legacy
script does not work.
|
|
Problem: Cannot drag a popup without a border.
Solution: Add the "dragall" option. (closes #9218)
|
|
Problem: Cannot drag popup window after click on a status line. (Sergey
Vlasov)
Solution: Reset on_status_line. (closes #9221)
|
|
Problem: zindex of popup windows not used when redrawing popup menu.
Solution: Check the zindex when redrawing the popup menu. (closes #9129,
closes #9089)
|
|
Problem: Popup window title with wide characters is truncated.
Solution: Use vim_strsize() instead of MB_CHARLEN(). (Naruhiko Nishino,
closes #8721)
|
|
Problem: Popup window test is flaky on MS-Windows with GUI.
Solution: Skip the check in this situation.
|
|
Problem: Test_popup_atcursor_pos() fails without the conceal feature.
Solution: Add a check for the conceal feature. (Dominique Pellé,
closes #8505)
|
|
Problem: popup_atcursor() uses wrong position with concealing.
Solution: Keep w_wcol in conceal_check_cursor_line(). (closes #8476)
|
|
Problem: Vim9: builtin function arguments not checked at compile time.
Solution: Add more argument type specs. Check arguments to test_setmouse()
and test_gui_mouse_event(). (Yegappan Lakshmanan, closes #8425)
|
|
Problem: Popup window test is a bit flaky.
Solution: Add a redraw command.
|
|
Problem: "%bd" tries to delete popup window buffers, which fails. (Ralf
Schandl)
Solution: Do not try to delete a popup window buffer. (closes #8349)
|
|
Problem: Multi-byte text in popup title shows up wrong.
Solution: Use the character width instead of the byte length. (Ralf Schandl,
closes #8267, closes #8264)
|
|
Problem: Second time a preview popup is opened highlight is not set.
(Gabriel Dupras)
Solution: Apply 'previewpopup' after getting the file. (closes #7928)
|
|
Problem: Popup_create() does not allow boolean for "cursorline".
Solution: Use dict_get_bool(). (issue #7869)
|
|
Problem: Internal error when popup with mask is zero height or width.
Solution: Bail out if width or height is zero. (closes #7831)
|
|
Problem: Popup window for text property may show in first screen line.
Solution: If the text position is invisible do not show the popup window.
(closes #7807)
|
|
Problem: Popup_setoptions() does not set textprop in other tab.
Solution: use win_valid_any_tab(). (closes #7788)
|
|
Problem: Popup_getoptions() does not get textprop from other tab.
Solution: use win_valid_any_tab(). (closes #7786)
|
|
Problem: Cannot use CTRL-N and CTRL-P in a popup menu.
Solution: Use CTRL-N like <Down> and CTRL-P like <Up>. (closes #7614)
|
|
Problem: Crash when popup mask contains zeroes.
Solution: Check boundaries properly. (closes #7569)
|
|
Problem: Various typos.
Solution: Fix spelling mistakes. (closes #7494)
|
|
Problem: Popupwin test for terminal buffer fails sometimes.
Solution: Wait for the prompt to appear.
|
|
Problem: Popupwin test for latin1 still fails sometimes.
Solution: Wait for the "cat" command to finish.
|
|
Problem: Popupwin test for latin1 sometimes fails.
Solution: Wait for the script to finish.
|
