Age | Commit message (Collapse) | Author |
|
Problem: Parameter of gui_gtk:gui_mch_browse incorrectly marked as
UNUSED.
Solution: Remove UNUSED flag.
closes: #12841
Signed-off-by: Christian Brabandt <cb@256bit.org>
Co-authored-by: Doug Kearns <dougkearns@gmail.com>
|
|
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11787)
|
|
Problem: The mode #defines are not clearly named.
Solution: Prepend MODE_. Renumber them to put the mapped modes first.
|
|
Problem: GTK: get assertion errors when scrolling a split window.
Solution: Use GDK_IS_DRAWABLE() on the scrollbar window. (closes #9982)
|
|
Problem: Various spelling mistakes in comments.
Solution: Fix the mistakes. (Dominique Pellé, closes #9416)
|
|
Problem: GTK3: with 'rightleft' set scrollbar may move unintentionally.
Solution: Ignore events while moving the scrollbar thumb. (closes #8958)
|
|
Problem: GTK: righthand scrollbar does not show with split window.
Solution: Adjust padding when two scrollbars are used. (Matt Wozniski,
closes #8324)
|
|
Problem: GTK menu tooltip moves the cursor.
Solution: Position the cursor after displaying the tooltip. Do not show the
tooltip when editing the command line.
|
|
Problem: GTK menu items don't show a tooltip.
Solution: Add a callback to show the tooltip. (Leonid V. Fedorenchik,
closes #8067, closes #7810)
|
|
Problem: The GTK GUI has a gap next to the scrollbar.
Solution: Calculate the scrollbar padding for GTK. (closes #8027)
|
|
Problem: GTK: error for redefining function. (Tony Mechelynck)
Solution: Remove "gtk_" prefix from local functions and prepend "gui_" to
global functions.
|
|
Problem: GTK3: using old file chooser.
Solution: Use native file chooser on GTK 3.20 and above. (Yogeshwar
Velingker, closes #6909)
|
|
Problem: Scrollbars not flush against the window edges when maximised.
Solution: Add padding. (Ken Takata, closes #5602, closes #6466)
|
|
Problem: Loops are repeated.
Solution: Use FOR_ALL_ macros. (Yegappan Lakshmanan, closes #5882)
|
|
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
|
|
Problem: Alloc() returning "char_u *" causes a lot of type casts.
Solution: Have it return "void *". (Mike Williams) Define ALLOC_ONE() to
check the simple allocations.
|
|
Problem: Using "int" for alloc() often results in compiler warnings.
Solution: Use "size_t" and remove type casts. Remove alloc_check(), Vim
only works with 32 bit ints anyway.
|
|
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982)
|
|
Problem: Macros for MS-Windows are inconsistent, using "32", "3264 and
others.
Solution: Use MSWIN for all MS-Windows builds. Use FEAT_GUI_MSWIN for the
GUI build. (Hirohito Higashi, closes #3932)
|
|
Problem: Various typos in comments.
Solution: Fix the typos.
|
|
Problem: Too many #ifdefs for GTK.
Solution: Define macros instead of using #ifdef. (Ken Takata, closes #3436)
|
|
Problem: GTK code has too many #ifdefs and building fails with GTK 2.10.
Solution: Always use gtk_widget_get_window() and define it for older GTK
versions. (Ken Takata, closes #3421)
|
|
Problem: Various small problems in source files.
Solution: Fix the problems.
|
|
Problem: Older GTK versions don't have gtk_entry_get_text_length().
Solution: Add a function with #ifdefs to take care of GTK version
differences. (Kazunobu Kuriyama, closes #2605)
|
|
Problem: GTK: :promtfind does not put focus on text input. (Adam Novak)
Solution: When re-opening the dialog put focus on the text input. (Kazunobu
Kuriyama, closes #2563)
|
|
Problem: W_WINCOL() is always the same.
Solution: Expand the macro.
|
|
Problem: FEAT_WINDOWS adds a lot of #ifdefs while it is nearly always
enabled and only adds 7% to the binary size of the tiny build.
Solution: Graduate FEAT_WINDOWS.
|
|
Problem: Crash when using some version of GTK 3.
Solution: Add #ifdefs around incrementing the menu index. (Kazunobu
Kuriyama)
|
|
Problem: Some macros are in lower case.
Solution: Make a few more macros upper case.
|
|
Problem: Some macros are in lower case.
Solution: Make a few more macros upper case. Avoid lower case macros use an
argument twice.
|
|
Problem: Build error on Fedora 23 with small features and gnome2.
Solution: Undefine ngettext(). (Hirohito Higashi)
|
|
Problem: Various problems with GTK 3.22.2.
Solution: Fix the problems, add #ifdefs. (Kazunobu Kuriyama)
|
|
Problem: Modelines in source code are inconsistant.
Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
|
|
Problem: GTK3 doesn't handle menu separaters properly.
Solution: Use gtk_separator_menu_item_new(). (Kazunobu Kuriyama)
|
|
Problem: Typo in button text.
Solution: Fix the typo. (Dominique Pelle)
|
|
Problem: GTK 3 is not supported.
Solution: Add GTK 3 support. (Kazunobu Kuriyama)
|
|
Problem: Using old style function declarations.
Solution: Change to new style function declarations. (script by Hirohito
Higashi)
|
|
Problem: gdk_pixbuf_new_from_inline() is deprecated.
Solution: Generate auto/gui_gtk_gresources.c. (Kazunobu Kazunobu,
closes #507)
|
|
Problem: Get GLIB warning when removing a menu item.
Solution: Reference menu-id and also call gtk_container_remove(). (Ivan
Krasilnikov)
|
|
Problem: Can't build GTK version with GTK 2.0.
Solution: Put GtkFileFilter declaration in the right place. (Yegappan
Lakshmanan)
|
|
Problem: No easy way to decide if b:browsefilter will work.
Solution: Add the browsefilter feature.
|
|
Problem: Vim on GTK does not support g:browsefilter.
Solution: Add a GtkFileFilter to the file chooser. (Christian Brabandt)
|
|
Problem: Function is sometimes unused.
Solution: Add #ifdef.
|
|
Problem: GTK gives an error when selecting a non-existent file.
Solution: Add a handler to avoid the error. (Christian Brabandt)
|
|
Problem: With GTK menu may be popping down.
Solution: Use event time instead of GDK_CURRENT_TIME. (Hong Xu)
|
|
Problem: When using ":make", typing the next command and then getting the
"reload" prompt the next command is (partly) eaten by the reload
prompt.
Solution: Accept ':' as a special character at the reload prompt to accept
the default choice and execute the command.
|
|
Problem: Clang warnings for dead code.
Solution: Remove it. (Carlo Teubner)
|
|
Problem: GTK: pressing Enter in inputdialog() doesn't work like clicking OK
as documented.
Solution: call gtk_entry_set_activates_default(). (Britton Kerin)
|
|
(James Vega)
|
|
|