summaryrefslogtreecommitdiffstats
path: root/src/drawline.c
AgeCommit message (Collapse)Author
2023-10-11patch 9.0.2017: linebreak applies for leading whitespacev9.0.2017Christian Brabandt
Problem: linebreak applies for leading whitespace Solution: only apply linebreak, once we have found non-breakat chars in the line closes: #13228 closes: #13243 Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-09-24patch 9.0.1938: multispace wrong when scrolling horizontallyv9.0.1938zeertzjq
Problem: multispace wrong when scrolling horizontally Solution: Update position in "multispace" or "leadmultispace" also in skipped chars. Reorder conditions to be more consistent. closes: #13145 closes: #13147 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-09-21patch 9.0.1923: curswant wrong on click with 've' and 'wrap' setv9.0.1923zeertzjq
Problem: curswant wrong on click with 've' and 'wrap' set Solution: Add w_leftcol to mouse click column. closes: #13142 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-09-11patch 9.0.1896: "below" virtual text doesn't work with 'rightleft'v9.0.1896zeertzjq
Problem: "below" virtual text doesn't work with 'rightleft'. Solution: Use column from right border with 'rightleft'. closes: #13071 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-09-02patch 9.0.1851: breakindent missing by virt textv9.0.1851zeertzjq
Problem: Virtual text at a column causes 'breakindent' and 'showbreak' to be missing (after patch 9.0.1124). Solution: Add check for "tp_col" in another place where TP_FLAG_WRAP is checked. closes: #12769 closes: #13008 closes: #13010 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-09-01patch 9.0.1836: display wrong with virttext, linebreak and breakindentv9.0.1836zeertzjq
Problem: Wrong display with "above" virtual text and 'linebreak' or 'breakindent' and 'showbreak'. Solution: Exclude size of "above" virtual text when calculating them. closes: #13000 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-28patch 9.0.1813: linebreak incorrect drawn with breakindentv9.0.1813zeertzjq
Problem: 'linebreak' is incorrectly drawn after 'breakindent'. Solution: Don't include 'breakindent' size when already after it. closes: #12937 closes: #12940 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-27patch 9.0.1800: Cursor position still wrong with 'showbreak' and virtual textv9.0.1800zeertzjq
Problem: Cursor position still wrong with 'showbreak' and virtual text after last character or 'listchars' "eol". Solution: Remove unnecessary w_wcol adjustment in curs_columns(). Also fix first char of virtual text not shown at the start of a screen line. closes: #12478 closes: #12532 closes: #12904 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-22patch 9.0.1783: Display issues with virt text smoothscroll and showbreakv9.0.1783zeertzjq
Problem: Wrong display with wrapping virtual text or unprintable chars, 'showbreak' and 'smoothscroll'. Solution: Don't skip cells taken by 'showbreak' in screen lines before "w_skipcol". Combined "n_skip" and "skip_cells". closes: #12597 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-20patch 9.0.1759: Visual highlight not working with cursor at end of screen linev9.0.1759zeertzjq
Problem: Visual highlight not working with cursor at end of screen line and 'showbreak'. Solution: Only update "vcol_prev" when drawing buffer text. closes: #12865 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-19patch 9.0.1756: failing cursorline sign testv9.0.1756Christian Brabandt
Problem: failing cursorline sign test Solution: only reset char attr, if cursorline option is not set Unfortunately, commit dbeadf05b6a152e7d9c5cc23d9202057f8e99884 causes a failure with the sign test Test_sign_cursor_position() The root cause is, that resetting the character attribute will also reset the existing cursor line highlighting and this breaks the test, that expects the cursor line highlighting to overrule the sign line highlighting. So change the condition to reset the character attribute by making sure that this only happens, if the 'cursorline' option is not active and the cursor is not at the same line as the line to be drawn closes: #12854 closes: #12859 Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-08-19patch 9.0.1749: Text property highlight doesn't override a sign highlight on TABv9.0.1749Christian Brabandt
Problem: Text property highlight doesn't override a sign highlight over a tab character Solution: Let text_property override tab highlighting This fixes a few problems of text properties: - text property highlighting when override=true does not overwrite TAB highlighting - text property highlighting when override=true does not overwrite TAB highlighting with :set list - text property highlighting is used instead of sign highlight after the actual text ends when signs are present with linehl is set closes: #21584 closes: #21592 Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-08-17patch 9.0.1731: blockwise Visual highlight not working with virtual textv9.0.1731zeertzjq
Problem: blockwise Visual highlight not working with virtual text Solution: Reset the correct variable at the end of virtual selection and Check for double-width char inside virtual text. closes: #12606 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-17patch 9.0.1725: cursor pos wrong after concealed text with 'virtualedit'v9.0.1725zeertzjq
Problem: Wrong cursor position when clicking after concealed text with 'virtualedit'. Solution: Store virtual columns in ScreenCols[] instead of text columns, and always use coladvance() when clicking. This also fixes incorrect curswant when clicking on a TAB, so now Test_normal_click_on_ctrl_char() asserts the same results as the ones before patch 9.0.0048. closes: #12808 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-13patch 9.0.1705: cursor position wrong when clicking on an unprintable charv9.0.1705zeertzjq
Problem: cursor position wrong when clicking on an unprintable char Solution: Don't update prev_ptr when wlv.n_extra is not zero. closes: #12664 Signed-off-by: Christian Brabandt <cb@256bit.org> Co-authored-by: zeertzjq <zeertzjq@outlook.com>
2023-08-12patch 9.0.1695: Crash with overlong textprop abovev9.0.1695Christian Brabandt
Problem: Crash with overlong textprop above Solution: Consider only positive padding closes: #12665 closes: #12661 Signed-off-by: Christian Brabandt <cb@256bit.org>
2023-06-10patch 9.0.1626: Visual area not shown when using 'showbreak'v9.0.1626Bram Moolenaar
Problem: Visual area not shown when using 'showbreak' and start of line is not visible. (Jaehwang Jung) Solution: Adjust "fromcol" for the space taken by 'showbreak'. (closes #12514)
2023-06-04patch 9.0.1606: using freed memory when 'foldcolumn' is setv9.0.1606zeertzjq
Problem: Using freed memory when 'foldcolumn' is set. Solution: Save extra pointer to free it later. (closes #12492)
2023-06-03patch 9.0.1602: stray character visible if marker on top of double-wide charv9.0.1602zeertzjq
Problem: Stray character is visible if 'smoothscroll' marker is displayed on top of a double-wide character. Solution: When overwriting a double-width character with the 'smoothscroll' marker clear the second half. (closes #12469)
2023-05-31patch 9.0.1595: line pointer becomes invalid when using spell checkingv9.0.1595Luuk van Baal
Problem: Line pointer becomes invalid when using spell checking. Solution: Call ml_get() at the right places. (Luuk van Baal, closes #12456)
2023-05-27patch 9.0.1585: weird use of static variables for spell checkingv9.0.1585Luuk van Baal
Problem: Weird use of static variables for spell checking. Solution: Move the variables to a structure and pass them from win_update() to win_line(). (Luuk van Baal, closes #12448)
2023-05-25patch 9.0.1578: SpellCap highlight not always updated when neededv9.0.1578Luuk van Baal
Problem: SpellCap highlight not always updated when needed. Solution: Handle updating line below closed fold and other situations where only part of the window is redrawn. (Luuk van Baal, closes #12428, closes #12420)
2023-05-02patch 9.0.1506: line number not displayed when using 'smoothscroll'v9.0.1506zeertzjq
Problem: Line number not displayed when using 'smoothscroll'. Solution: Adjust condition for showing the line number. (closes #12333)
2023-04-23patch 9.0.1482: crash when textprop has a very large "padding" valuev9.0.1482Bram Moolenaar
Problem: Crash when textprop has a very large "padding" value. (Yegappan Lakshmanan) Solution: Avoid the "after" count to go negative.
2023-04-17patch 9.0.1463: virtual text truncation only works with Unicode 'encoding'v9.0.1463h-east
Problem: Virtual text truncation only works with Unicode 'encoding'. Solution: Convert the ellipsis character to 'encoding' if needed. (Hirohito Higashi, closes #12233)
2023-03-02patch 9.0.1373: wrong text displayed when using both 'linebreak' and 'list'v9.0.1373h-east
Problem: Wrong text displayed when using both 'linebreak' and 'list'. Solution: Only set "c_extra" to NUL when "p_extra" is not empty. (Hirohito Higashi, closes #12065)
2023-02-19patch 9.0.1326: relative line number not updated with virtual text abovev9.0.1326Bram Moolenaar
Problem: Relative line number not updated with virtual text above. Solution: Adjust the row for the line number for virtual text above. (closes #12004)
2023-02-19patch 9.0.1325: 'colorcolumn' highlight wrong with virtual text abovev9.0.1325Bram Moolenaar
Problem: 'colorcolumn' highlight wrong with virtual text above. Solution: Adjust column of 'colorcolumn' for text propertly. (closes #12004)
2023-02-12patch 9.0.1304: "$" for 'list' option displayed in wrong positionv9.0.1304Bram Moolenaar
Problem: "$" for 'list' option displayed in wrong position when there are text properties. Solution: Adjust logic for order of displayed items. (closes #11959)
2023-02-11patch 9.0.1301: virtual text below empty line not displayedv9.0.1301Bram Moolenaar
Problem: Virtual text below empty line not displayed. Solution: Adjust flags and computations. (closes #11959)
2023-01-21patch 9.0.1226: spurious empty line when using text propertiesv9.0.1226Bram Moolenaar
Problem: Spurious empty line when using text propertie and virtual text. Solution: Do not set "text_prop_follows" when the other text property is not virtual text. (closes #11846)
2023-01-04patch 9.0.1141: 'cursorcolumn' and 'colorcolumn' wrong after concealingv9.0.1141Alexey Radkov
Problem: 'cursorcolumn' and 'colorcolumn' wrong after concealing and wrapping line. Solution: Reset "wlv.vcol_off" after each screen line. (Alexey Radkov, closes #11777)
2023-01-01patch 9.0.1124: virtual text at a column position is truncatedv9.0.1124Bram Moolenaar
Problem: Virtual text at a column position is truncated at the window edge. (Yegappan Lakshmanan) Solution: Do not truncated virtual text that is placed at a column.
2022-12-26patch 9.0.1098: code uses too much indentv9.0.1098Yegappan Lakshmanan
Problem: Code uses too much indent. Solution: Use an early return. (Yegappan Lakshmanan, closes #11747)
2022-12-17patch 9.0.1069: diff mode highlight fails for special charactersv9.0.1069Bram Moolenaar
Problem: Diff mode highlight fails for special characters. Solution: Adjust condition for setting "diff_hlf".
2022-12-17patch 9.0.1067: in diff mode virtual text is highlighted incorrectlyv9.0.1067Bram Moolenaar
Problem: In diff mode virtual text is highlighted incorrectly. (Rick Howe) Solution: Do not use diff attributes for virtual text. (closes #11714)
2022-12-12patch 9.0.1048: with "screenline" in 'culopt' cursorline highlight is wrongv9.0.1048zeertzjq
Problem: With "screenline" in 'culopt' cursorline highlight is wrong. Solution: Apply the priority logic also when "screenline is in 'culopt'. (closes #11696)
2022-12-06patch 9.0.1019: 'smoothscroll' and virtual text above don't work togetherv9.0.1019Bram Moolenaar
Problem: 'smoothscroll' and virtual text above don't work together. (Yee Cheng Chin) Solution: Skip virtual text above when w_skipcol is non-zero. (closes #11665)
2022-12-02patch 9.0.0995: padding before virtual text is highlightedv9.0.0995Bram Moolenaar
Problem: Padding before virtual text below is highlighted when 'number' and 'nowrap' are set. Solution: Save and restore n_attr_skip. (closes #11643)
2022-12-02patch 9.0.0991: crash when reading help index with various options setv9.0.0991Bram Moolenaar
Problem: Crash when reading help index with various options set. (Marius Gedminas) Solution: Do not set wlv.c_extra to NUL when wlv.p_extra is NULL. (closes #11651)
2022-12-01patch 9.0.0982: 'cursorline' not drawn before virtual text belowv9.0.0982Bram Moolenaar
Problem: 'cursorline' not drawn before virtual text below. Solution: Add the 'cursorline' attribute to the empty space. (closes #11647)
2022-11-29patch 9.0.0975: virtual text below empty line misplaced when 'number' setv9.0.0975Bram Moolenaar
Problem: Virtual text below an empty line is misplaced when 'number' is set. Solution: Adjust the computations. (closes #11629)
2022-11-27patch 9.0.0962: virtual text below cannot be placed below empty linesv9.0.0962porygonisaduck
Problem: Virtual text below cannot be placed below empty lines. Solution: Add one character. (James Alvarado, closes #11606, closes #11520)
2022-11-24patch 9.0.0945: failures in the cursorline testv9.0.0945Bram Moolenaar
Problem: Failures in the cursorline test. Solution: Reset extra_attr only after a text property.
2022-11-24patch 9.0.0944: 'cursorline' causes virtual text highlight to continuev9.0.0944Bram Moolenaar
Problem: 'cursorline' causes virtual text highlight to continue. Solution: Save and restore line_attr. (closes #11588)
2022-11-18patch 9.0.0905: virtual text after the line wraps when 'wrap' is offv9.0.0905Bram Moolenaar
Problem: Virtual text after the line wraps when 'wrap' is off. Solution: Only set text_prop_follows when wrapping. (closes #11463)
2022-11-17patch 9.0.0894: virtual text property highlight ignores window backgroundv9.0.0894Bram Moolenaar
Problem: Virtual text property highlight ignores window background. Solution: Combine text prop attribute with win_attr into extra_attr. (closes #11462)
2022-11-16patch 9.0.0891: virtual text below after match has wrong highlightv9.0.0891Bram Moolenaar
Problem: Virtual text below after match has wrong highlight. Solution: Restore search_attr only after the virtual text. (closes #11446)
2022-11-02patch 9.0.0828: various typosv9.0.0828dundargoc
Problem: Various typos. Solution: Correct typos. (closes #11432)
2022-10-17patch 9.0.0784: text prop "above" not right with 'number' and "n" in 'cpo'v9.0.0784Bram Moolenaar
Problem: Text prop "above" not displayed correctly with 'number' and "n" in 'cpo'. Solution: Draw the line number column until the line text is reached.