| Age | Commit message (Collapse) | Author |
|---|
|
Problem: is*() and to*() function may be unsafe
Solution: Add SAFE_* macros and start using those instead
(Keith Thompson)
Use SAFE_() macros for is*() and to*() functions
The standard is*() and to*() functions declared in <ctype.h> have
undefined behavior for negative arguments other than EOF. If plain char
is signed, passing an unchecked value from argv for from user input
to one of these functions has undefined behavior.
Solution: Add SAFE_*() macros that cast the argument to unsigned char.
Most implementations behave sanely for negative arguments, and most
character values in practice are non-negative, but it's still best
to avoid undefined behavior.
The change from #13347 has been omitted, as this has already been
separately fixed in commit ac709e2fc0db6d31abb7da96f743c40956b60c3a
(v9.0.2054)
fixes: #13332
closes: #13347
Signed-off-by: Keith Thompson <Keith.S.Thompson@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
|
|
Problem: Code is indented more than needed.
Solution: Use an early return to reduce indentation. (Yegappan Lakshmanan,
closes #11769)
|
|
Problem: Various warnings from clang on MS-Windows.
Solution: Avoid the warnings. (Yegappan Lakshmanan, closes #10553)
|
|
Problem: Clang on MS-Windows produces warnings.
Solution: Avoid the warnings. (Yegappan Lakshmanan, closes #10546)
|
|
Problem: Various warnings from clang on MS-Windows.
Solution: Fix the code to avoid the warnings. (Yegappan Lakshmanan,
closes #10538)
|
|
Problem: MS-Windows: illegal memory access in installer when using
"create-directories" as the final argument.
Solution: Check the argument count. (Cam Sinclair, closes #9844)
|
|
Problem: MS-Windows: reported version lacks patchlevel, causing some update
tools to update too often. (Klaus Frank)
Solution: Add the patchlevel to the version. (Christian Brabandt)
|
|
Problem: Computing array length is done in various ways.
Solution: Use ARRAY_LENGTH everywhere. (Ken Takata, closes #8305)
|
|
Problem: MS-Windows installer contains old stuff.
Solution: Rely on Windows NT. (Ken Takata, closes #5832)
|
|
Problem: MS-Windows uninstall may delete wrong batch file.
Solution: Add specific marker in the generated batch file. (Ken Takata,
closes #5654)
|
|
Problem: Using old C style comments.
Solution: Use // comments where appropriate.
|
|
Problem: Some files have a weird name to fit in 8.3 characters.
Solution: Use a nicer names.
|
|
Problem: Unnecessary type casts.
Solution: Remove type casts from alloc() and lalloc() calls. (Mike Williams)
|
|
Problem: Borland support is outdated and doesn't work.
Solution: Remove Borland support, there are other (free) compilers
available. (Thomas Dziedzic, Ken Takata, closes #4364)
|
|
Problem: No support for Windows on ARM64.
Solution: Add ARM64 support (Leendert van Doorn)
|
|
Problem: Too many curly braces.
Solution: Remove curly braces where they are not needed. (Hirohito Higashi,
closes #3982)
|
|
Problem: Dosinstall still has buffer overflow problems.
Solution: Adjust buffer sizes. (Yasuhiro Matsumoto, closes #4002)
|
|
Problem: Compilation warnings when building the MS-Windows installer.
Solution: Fix buffer sizes. (Yasuhiro Matsumoto, closes #3999)
|
|
Problem: Compiler warning for adding to NULL pointer and a condition that
is always true.
Solution: Check for NULL pointer before adding. Remove useless "if".
(Friedirch, closes #3913)
|
|
Problem: Compiler warning for sprintf() argument.
Solution: Add type cast.
|
|
Problem: NSIS installer is outdated.
Solution: Use modern syntax, MUI2 and make it work better. Add translations.
(Ken Takata, closes #3501)
|
|
Problem: Compilation error in gvimext.cpp.
Solution: Return a value. Also fix using uninitialized variable.
|
|
Problem: Help message in dosinst.c is outdated.
Solution: Update the comment. (Ken Takata, closes #3626)
|
|
Problem: MS-Windows installer uses different $HOME than Vim.
Solution: Use the Vim logic also in the MS-Windows installer. (Ken Takata,
closes #3564)
|
|
Problem: Dosinst command has a few flaws.
Solution: Register DisplayIcon, DisplayVersion and Publisher for the
uninstaller. (closes #3485) Don't set 'diffexpr' if internal diff
is supported. Allow for using Vi compatible from the command line.
Remove needless sleeps. Add comments in the generated _vimrc.
(Ken Takata, closes #3525)
|
|
Problem: MS-Windows: the text "self-installing" confuses some users.
Solution: Remove the text from the uninstall entry. (closes #3337)
|
|
Problem: URL in install program still points to SourceForge.
Solution: Change it to www.vim.org. (closes #3100)
|
|
Problem: MS-Windows: script for vimdiff can't handle ! chars.
Solution: Escape the ! chars. (Hans Ginzel, closes #2896)
|
|
Problem: Some macros are used without a semicolon, causing auto-indent to be
wrong.
Solution: Use the do-while(0) trick. (Ozaki Kiichi, closes #2729)
|
|
Problem: Various small problems in source files.
Solution: Fix the problems.
|
|
Problem: Typo in dos installer.
Solution: Remove comma.
|
|
Problem: MS-Windows users are confused about default mappings.
Solution: Don't map keys in the console where they don't work. Add a choice
in the installer to use MS-Windows key bindings or not. (Christian
Brabandt, Ken Takata, closes #2093)
|
|
Problem: MS-Windows: missing 32 and 64 bit files in installer.
Solution: Include both 32 and 64 bit GvimExt and related dll files. Remove
old Windows code from the installer. (Ken Takata, closes #2144)
|
|
Problem: Modelines in source code are inconsistant.
Solution: Use the same line in most files. Add 'noet'. (Naruhiko Nishino)
|
|
Problem: The default vimrc for Windows is very conservative.
Solution: Use the defaults.vim in the Windows installer.
|
|
Problem: Doubled semicolons.
Solution: Reduce to one. (Dominique Pelle)
|
|
Problem: Generated .bat files do not support --nofork.
Solution: Add check for --nofork. Also add "setlocal". (Kevin Cantú,
closes #659)
|
|
Problem: Dos installer uses an old way to escape spaces in the diff
command.
Solution: Adjust the quoting to the new default shellxquote. (Ben Fritz)
|
|
Problem: DOS installer creates shortcut without a path, resulting in the
current directory to be C:\Windows\system32.
Solution: Use environment variables.
|
|
Problem: Typos in source files.
Solution: Fix the typos. (Ken Takata)
|
|
Problem: The dosinst.c program has a buffer overflow. (Thomas Gwae)
Solution: Ignore $VIMRUNTIME if it is too long.
|
|
|
|
|
|
|
|
|
|
|
|
Cleanup white space.
|
|
|
|
Reilly)
|
|
finish, no need for the user to press Enter.
|
