diff options
author | Bram Moolenaar <Bram@vim.org> | 2022-08-29 20:45:16 +0100 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2022-08-29 20:45:16 +0100 |
commit | 4f1b083be43f351bc107541e7b0c9655a5d2c0bb (patch) | |
tree | dc39650176462f3bcd38f7d789d3f8c6b22c3dd0 /src | |
parent | 37fef16c225eabed28a3c7a0542d2eeef30d812b (diff) |
patch 9.0.0322: crash when no errors and 'quickfixtextfunc' is setv9.0.0322
Problem: Crash when no errors and 'quickfixtextfunc' is set.
Solution: Do not handle errors if there aren't any.
Diffstat (limited to 'src')
-rw-r--r-- | src/quickfix.c | 2 | ||||
-rw-r--r-- | src/testdir/test_quickfix.vim | 16 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 19 insertions, 1 deletions
diff --git a/src/quickfix.c b/src/quickfix.c index 78f6880d80..ab288e0c4d 100644 --- a/src/quickfix.c +++ b/src/quickfix.c @@ -4761,7 +4761,7 @@ qf_fill_buffer(qf_list_T *qfl, buf_T *buf, qfline_T *old_last, int qf_winid) } // Check if there is anything to display - if (qfl != NULL) + if (qfl != NULL && qfl->qf_start != NULL) { char_u dirname[MAXPATHL]; int invalid_val = FALSE; diff --git a/src/testdir/test_quickfix.vim b/src/testdir/test_quickfix.vim index 31d36ef1d6..ee43cb685a 100644 --- a/src/testdir/test_quickfix.vim +++ b/src/testdir/test_quickfix.vim @@ -4107,6 +4107,22 @@ func Xgetlist_empty_tests(cchar) endif endfunc +func Test_empty_list_quickfixtextfunc() + " This was crashing. Can only reproduce by running it in a separate Vim + " instance. + let lines =<< trim END + func s:Func(o) + cgetexpr '0' + endfunc + cope + let &quickfixtextfunc = 's:Func' + cgetfile [ex + END + call writefile(lines, 'Xquickfixtextfunc') + call RunVim([], [], '-e -s -S Xquickfixtextfunc -c qa') + call delete('Xquickfixtextfunc') +endfunc + func Test_getqflist() call Xgetlist_empty_tests('c') call Xgetlist_empty_tests('l') diff --git a/src/version.c b/src/version.c index a1fc74f82b..be50c42065 100644 --- a/src/version.c +++ b/src/version.c @@ -708,6 +708,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 322, +/**/ 321, /**/ 320, |