diff options
author | Bram Moolenaar <Bram@vim.org> | 2016-08-22 21:40:29 +0200 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2016-08-22 21:40:29 +0200 |
commit | f267f8bdf777073e392ada5b31d837c7b6090eb4 (patch) | |
tree | 304b0775c08e167320e8d9c6f15c61baafa493a0 /src | |
parent | 9baf297c99cc35adb921bee04369499d76438889 (diff) |
patch 7.4.2240v7.4.2240
Problem: Tests using the sleep time can be flaky.
Solution: Use reltime() if available. (Partly by Shane Harper)
Diffstat (limited to 'src')
-rw-r--r-- | src/testdir/shared.vim | 18 | ||||
-rw-r--r-- | src/testdir/test_timers.vim | 24 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 37 insertions, 7 deletions
diff --git a/src/testdir/shared.vim b/src/testdir/shared.vim index edc3c386a8..24b05bec6a 100644 --- a/src/testdir/shared.vim +++ b/src/testdir/shared.vim @@ -109,19 +109,31 @@ func s:kill_server(cmd) endfunc " Wait for up to a second for "expr" to become true. -" Return time slept in milliseconds. +" Return time slept in milliseconds. With the +reltime feature this can be +" more than the actual waiting time. Without +reltime it can also be less. func WaitFor(expr) - let slept = 0 + " using reltime() is more accurate, but not always available + if has('reltime') + let start = reltime() + else + let slept = 0 + endif for i in range(100) try if eval(a:expr) + if has('reltime') + return float2nr(reltimefloat(reltime(start)) * 1000) + endif return slept endif catch endtry - let slept += 10 + if !has('reltime') + let slept += 10 + endif sleep 10m endfor + return 1000 endfunc " Run Vim, using the "vimcmd" file and "-u NORC". diff --git a/src/testdir/test_timers.vim b/src/testdir/test_timers.vim index 46777d1ea5..5b9e5c48aa 100644 --- a/src/testdir/test_timers.vim +++ b/src/testdir/test_timers.vim @@ -19,7 +19,11 @@ func Test_oneshot() let timer = timer_start(50, 'MyHandler') let slept = WaitFor('g:val == 1') call assert_equal(1, g:val) - call assert_inrange(30, 100, slept) + if has('reltime') + call assert_inrange(50, 100, slept) + else + call assert_inrange(20, 100, slept) + endif endfunc func Test_repeat_three() @@ -27,7 +31,11 @@ func Test_repeat_three() let timer = timer_start(50, 'MyHandler', {'repeat': 3}) let slept = WaitFor('g:val == 3') call assert_equal(3, g:val) - call assert_inrange(80, 200, slept) + if has('reltime') + call assert_inrange(150, 200, slept) + else + call assert_inrange(80, 200, slept) + endif endfunc func Test_repeat_many() @@ -48,7 +56,11 @@ func Test_with_partial_callback() call timer_start(50, s:meow.bite) let slept = WaitFor('g:val == 1') call assert_equal(1, g:val) - call assert_inrange(30, 100, slept) + if has('reltime') + call assert_inrange(50, 100, slept) + else + call assert_inrange(20, 100, slept) + endif endfunc func Test_retain_partial() @@ -109,7 +121,11 @@ func Test_paused() let slept = WaitFor('g:val == 1') call assert_equal(1, g:val) - call assert_inrange(0, 10, slept) + if has('reltime') + call assert_inrange(0, 30, slept) + else + call assert_inrange(0, 10, slept) + endif endfunc " vim: shiftwidth=2 sts=2 expandtab diff --git a/src/version.c b/src/version.c index 1cd659f861..88ea46c8b2 100644 --- a/src/version.c +++ b/src/version.c @@ -764,6 +764,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 2240, +/**/ 2239, /**/ 2238, |