diff options
author | Sean Dewar <6256228+seandewar@users.noreply.github.com> | 2024-03-05 20:39:07 +0100 |
---|---|---|
committer | Christian Brabandt <cb@256bit.org> | 2024-03-05 20:39:07 +0100 |
commit | 4bb505e28cac0389561fff78d8bbe0319c2bcf2f (patch) | |
tree | f99457a9745c01a0a6edc83121431a681aae6716 /runtime | |
parent | e1051924c7ca1f9f9346daef756619d4e7fb7a83 (diff) |
patch 9.1.0150: Several minor 'winfixbuf' issuesv9.1.0150
Problem: several minor 'winfixbuf' issues exist, mostly relating to the
quickfix list
Solution: address them and adjust tests. Retab and reflow a few things too.
(Sean Dewar)
Things touched include:
- Replace the semsgs with gettext'd emsgs.
- Handle window switching in ex_listdo properly, so curbuf and curwin
are kept in-sync and trigger autocommands; handle those properly.
- Don't change the list entry index in qf_jump_edit_buffer if we fail
due to 'wfb' (achieved by returning FAIL; QF_ABORT should only be used
if the list was changed).
- Make qf_jump_edit_buffer actually switch to prevwin when using `:cXX`
commands **outside** of the list window if 'wfb' is set in curwin.
Handle autocommands properly in case they mess with the list.
NOTE: previously, it seemed to split if 'wfb' was set, but do nothing
and fail if prevwin is *valid*. This behaviour seemed strange, and maybe
unintentional? Now it aligns more with what's described for the `:cXX`
commands in the original PR description when used outside a list window,
I think.
- In both functions, only consider prevwin if 'wfb' isn't set for it;
fallback to splitting otherwise.
- Use win_split to split. Not sure if there was a specific reason for
using ex_splitview. win_split is simpler and respects modifiers like
:vertical that may have been used. Plus, its return value can be checked
for setting opened_window in qf code (technically win_split_ins autocmds
could immediately close it or change windows, in which the qf code might
close some other window on failure; it's already the case elsewhere,
though).
closes: #14142
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
Diffstat (limited to 'runtime')
-rw-r--r-- | runtime/doc/message.txt | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/runtime/doc/message.txt b/runtime/doc/message.txt index 6e1122d1e7..4abdd9e5d9 100644 --- a/runtime/doc/message.txt +++ b/runtime/doc/message.txt @@ -1,4 +1,4 @@ -*message.txt* For Vim version 9.1. Last change: 2024 Mar 03 +*message.txt* For Vim version 9.1. Last change: 2024 Mar 05 VIM REFERENCE MANUAL by Bram Moolenaar @@ -122,7 +122,7 @@ wiped out a buffer which contains a mark or is referenced in another way. You cannot have two buffers with exactly the same name. This includes the path leading to the file. - *E1513* > + *E1513* Cannot edit buffer. 'winfixbuf' is enabled ~ If a window has 'winfixbuf' enabled, you cannot change that window's current |