diff options
| author | Doug Kearns <dougkearns@gmail.com> | 2024-01-14 20:59:02 +0100 |
|---|---|---|
| committer | Christian Brabandt <cb@256bit.org> | 2024-01-14 21:02:54 +0100 |
| commit | 93197fde0f1db09b1e495cf3eb14a8f42c318b80 (patch) | |
| tree | 1650d736f95a604255c854d25b93d85a8ed71e4a /runtime/ftplugin/vb.vim | |
| parent | d7d560374b836e62e180914b6e85f0eb20557a54 (diff) | |
runtime(ftplugin): Use "*" browsefilter pattern to match "All Files"
Problem: The "*.*" browsefilter pattern only matches all files on
Windows (Daryl Lee)
Solution: Use "*" to filter on all platforms but keep "*.*" as the label
text on Windows. (Fixes #12685, Doug Kearns)
The *.* browsefilter pattern used to match "All Files" on Windows is a
legacy of the DOS 8.3 filename wildcard matching algorithm. For reasons
of backward compatibility this still works on Windows to match all
files, even those without an extension.
However, this pattern only matches filenames containing a dot on other
platforms. This often makes files without an extension difficult to
access from the file dialog, e.g., "Makefile"
On Windows it is still standard practice to use "*.*" for the filter
label so ftplugins should use "All Files (*.*)" on Windows and "All
Files (*)" on other platforms. This matches Vim's default browsefilter
values.
This commit also normalises the browsefilter conditional test to check
for the Win32 and GTK GUI features and an unset b:browsefilter.
closes: #12759
Signed-off-by: Doug Kearns <dougkearns@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
Diffstat (limited to 'runtime/ftplugin/vb.vim')
| -rw-r--r-- | runtime/ftplugin/vb.vim | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/runtime/ftplugin/vb.vim b/runtime/ftplugin/vb.vim index 5a9548115b..94a2f35ff3 100644 --- a/runtime/ftplugin/vb.vim +++ b/runtime/ftplugin/vb.vim @@ -2,7 +2,7 @@ " Language: Visual Basic (ft=vb) " Maintainer: Doug Kearns <dougkearns@gmail.com> " Previous Maintainer: Johannes Zellner <johannes@zellner.org> -" Last Change: 2021 Nov 17 +" Last Change: 2024 Jan 14 if exists("b:did_ftplugin") finish @@ -62,8 +62,12 @@ endif if (has("gui_win32") || has("gui_gtk")) && !exists("b:browsefilter") let b:browsefilter = "Visual Basic Source Files (*.bas)\t*.bas\n" . - \ "Visual Basic Form Files (*.frm)\t*.frm\n" . - \ "All Files (*.*)\t*.*\n" + \ "Visual Basic Form Files (*.frm)\t*.frm\n" + if has("win32") + let b:browsefilter .= "All Files (*.*)\t*\n" + else + let b:browsefilter .= "All Files (*)\t*\n" + endif let b:undo_ftplugin .= " | unlet! b:browsefilter" endif |