diff options
author | Bram Moolenaar <Bram@vim.org> | 2020-08-05 12:32:38 +0200 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2020-08-05 12:32:38 +0200 |
commit | 3c1c9fd94bc80871119a8519f3b881595082a6c0 (patch) | |
tree | 358c5fd31972aad23055b1f9c794aacde70c355d | |
parent | c753478b82613df37b145764e27f5514542edb97 (diff) |
patch 8.2.1371: Vim9: no error for missing white space around operatorv8.2.1371
Problem: Vim9: no error for missing white space around operator.
Solution: Check for white space around && and ||.
-rw-r--r-- | src/eval.c | 28 | ||||
-rw-r--r-- | src/testdir/test_vim9_expr.vim | 34 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 64 insertions, 0 deletions
diff --git a/src/eval.c b/src/eval.c index 6411ffa146..a9c36ac38c 100644 --- a/src/eval.c +++ b/src/eval.c @@ -2242,11 +2242,25 @@ eval2(char_u **arg, typval_T *rettv, evalarg_T *evalarg) if (getnext) *arg = eval_next_line(evalarg_used); else + { + if (evaluate && in_vim9script() && !VIM_ISWHITE(p[-1])) + { + error_white_both(p, 2); + clear_tv(rettv); + return FAIL; + } *arg = p; + } /* * Get the second variable. */ + if (evaluate && in_vim9script() && !IS_WHITE_OR_NUL((*arg)[2])) + { + error_white_both(p, 2); + clear_tv(rettv); + return FAIL; + } *arg = skipwhite_and_linebreak(*arg + 2, evalarg_used); evalarg_used->eval_flags = !result ? orig_flags : orig_flags & ~EVAL_EVALUATE; @@ -2359,11 +2373,25 @@ eval3(char_u **arg, typval_T *rettv, evalarg_T *evalarg) if (getnext) *arg = eval_next_line(evalarg_used); else + { + if (evaluate && in_vim9script() && !VIM_ISWHITE(p[-1])) + { + error_white_both(p, 2); + clear_tv(rettv); + return FAIL; + } *arg = p; + } /* * Get the second variable. */ + if (evaluate && in_vim9script() && !IS_WHITE_OR_NUL((*arg)[2])) + { + error_white_both(p, 2); + clear_tv(rettv); + return FAIL; + } *arg = skipwhite_and_linebreak(*arg + 2, evalarg_used); evalarg_used->eval_flags = result ? orig_flags : orig_flags & ~EVAL_EVALUATE; diff --git a/src/testdir/test_vim9_expr.vim b/src/testdir/test_vim9_expr.vim index aa7aed72a1..70813377b5 100644 --- a/src/testdir/test_vim9_expr.vim +++ b/src/testdir/test_vim9_expr.vim @@ -175,6 +175,23 @@ def Test_expr2_vimscript() END CheckScriptSuccess(lines) + # check white space + lines =<< trim END + vim9script + let var = v:true||v:true + END + CheckScriptFailure(lines, 'E1004:') + lines =<< trim END + vim9script + let var = v:true ||v:true + END + CheckScriptFailure(lines, 'E1004:') + lines =<< trim END + vim9script + let var = v:true|| v:true + END + CheckScriptFailure(lines, 'E1004:') + # check keeping the value lines =<< trim END vim9script @@ -279,6 +296,23 @@ def Test_expr3_vimscript() END CheckScriptSuccess(lines) + # check white space + lines =<< trim END + vim9script + let var = v:true&&v:true + END + CheckScriptFailure(lines, 'E1004:') + lines =<< trim END + vim9script + let var = v:true &&v:true + END + CheckScriptFailure(lines, 'E1004:') + lines =<< trim END + vim9script + let var = v:true&& v:true + END + CheckScriptFailure(lines, 'E1004:') + # check keeping the value lines =<< trim END vim9script diff --git a/src/version.c b/src/version.c index 5246d84c2e..9d06cd20e3 100644 --- a/src/version.c +++ b/src/version.c @@ -755,6 +755,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1371, +/**/ 1370, /**/ 1369, |