diff options
author | Bram Moolenaar <Bram@vim.org> | 2017-09-17 19:08:02 +0200 |
---|---|---|
committer | Bram Moolenaar <Bram@vim.org> | 2017-09-17 19:08:02 +0200 |
commit | 8adb0d03ca2694922da915356d7ede05e31c5a5c (patch) | |
tree | 02beb7a3d74b14f880e22000ba1586bb4961fee9 | |
parent | 4033c55eca575777718c0701e26635a0cc47d907 (diff) |
patch 8.0.1119: quitting a split terminal window kills the jobv8.0.1119
Problem: Quitting a split terminal window kills the job. (Yasuhiro
Matsumoto)
Solution: Only stop terminal job if it is the last window.
-rw-r--r-- | src/buffer.c | 40 | ||||
-rw-r--r-- | src/testdir/test_terminal.vim | 17 | ||||
-rw-r--r-- | src/version.c | 2 |
3 files changed, 39 insertions, 20 deletions
diff --git a/src/buffer.c b/src/buffer.c index 110dada7a6..7040bb1005 100644 --- a/src/buffer.c +++ b/src/buffer.c @@ -466,8 +466,27 @@ close_buffer( int del_buf = (action == DOBUF_DEL || action == DOBUF_WIPE); int wipe_buf = (action == DOBUF_WIPE); + /* + * Force unloading or deleting when 'bufhidden' says so. + * The caller must take care of NOT deleting/freeing when 'bufhidden' is + * "hide" (otherwise we could never free or delete a buffer). + */ + if (buf->b_p_bh[0] == 'd') /* 'bufhidden' == "delete" */ + { + del_buf = TRUE; + unload_buf = TRUE; + } + else if (buf->b_p_bh[0] == 'w') /* 'bufhidden' == "wipe" */ + { + del_buf = TRUE; + unload_buf = TRUE; + wipe_buf = TRUE; + } + else if (buf->b_p_bh[0] == 'u') /* 'bufhidden' == "unload" */ + unload_buf = TRUE; + #ifdef FEAT_TERMINAL - if (bt_terminal(buf)) + if (bt_terminal(buf) && (buf->b_nwindows == 1 || del_buf)) { if (term_job_running(buf->b_term)) { @@ -489,26 +508,7 @@ close_buffer( wipe_buf = TRUE; } } - else #endif - /* - * Force unloading or deleting when 'bufhidden' says so. - * The caller must take care of NOT deleting/freeing when 'bufhidden' is - * "hide" (otherwise we could never free or delete a buffer). - */ - if (buf->b_p_bh[0] == 'd') /* 'bufhidden' == "delete" */ - { - del_buf = TRUE; - unload_buf = TRUE; - } - else if (buf->b_p_bh[0] == 'w') /* 'bufhidden' == "wipe" */ - { - del_buf = TRUE; - unload_buf = TRUE; - wipe_buf = TRUE; - } - else if (buf->b_p_bh[0] == 'u') /* 'bufhidden' == "unload" */ - unload_buf = TRUE; #ifdef FEAT_AUTOCMD /* Disallow deleting the buffer when it is locked (already being closed or diff --git a/src/testdir/test_terminal.vim b/src/testdir/test_terminal.vim index a4031cedf1..17167e89ff 100644 --- a/src/testdir/test_terminal.vim +++ b/src/testdir/test_terminal.vim @@ -82,6 +82,23 @@ func Test_terminal_wipe_buffer() unlet g:job endfunc +func Test_terminal_split_quit() + let buf = Run_shell_in_terminal({}) + call term_wait(buf) + split + quit! + call term_wait(buf) + sleep 50m + call assert_equal('run', job_status(g:job)) + + quit! + call WaitFor('job_status(g:job) == "dead"') + call assert_equal('dead', job_status(g:job)) + + exe buf . 'bwipe' + unlet g:job +endfunc + func Test_terminal_hide_buffer() let buf = Run_shell_in_terminal({}) setlocal bufhidden=hide diff --git a/src/version.c b/src/version.c index 21ecc93445..893de43ac6 100644 --- a/src/version.c +++ b/src/version.c @@ -762,6 +762,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1119, +/**/ 1118, /**/ 1117, |