diff options
| author | Carl Lerche <me@carllerche.com> | 2020-05-12 15:09:43 -0700 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-05-12 15:09:43 -0700 |
| commit | fb7dfcf4322b5e60604815aea91266b88f0b7823 (patch) | |
| tree | aeba04a918be8a00eb09f6001a4f7946bd188c66 /tokio/src/sync/batch_semaphore.rs | |
| parent | a32f918671ef641affbfcc4d4005ab738da795df (diff) | |
sync: use intrusive list strategy for broadcast (#2509)
Previously, in the broadcast channel, receiver wakers were passed to the
sender via an atomic stack with allocated nodes. When a message was
sent, the stack was drained. This caused a problem when many receivers
pushed a waiter node then dropped. The waiter node remained indefinitely
in cases where no values were sent.
This patch switches broadcast to use the intrusive linked-list waiter
strategy used by `Notify` and `Semaphore.
Diffstat (limited to 'tokio/src/sync/batch_semaphore.rs')
| -rw-r--r-- | tokio/src/sync/batch_semaphore.rs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tokio/src/sync/batch_semaphore.rs b/tokio/src/sync/batch_semaphore.rs index 698e908e..f5bcc1b9 100644 --- a/tokio/src/sync/batch_semaphore.rs +++ b/tokio/src/sync/batch_semaphore.rs @@ -186,7 +186,7 @@ impl Semaphore { /// Release `rem` permits to the semaphore's wait list, starting from the /// end of the queue. - /// + /// /// If `rem` exceeds the number of permits needed by the wait list, the /// remainder are assigned back to the semaphore. fn add_permits_locked(&self, mut rem: usize, waiters: MutexGuard<'_, Waitlist>) { |