Do not need to dup() the tty fd sent from the client because it is

already dup()d again later. Fixes a leak seen by espie@.

1 files changed, 4 insertions, 6 deletions

diff --git a/server-client.c b/server-client.c
index 059a5c89..695c4e48 100644
--- a/server-client.c
+++ b/server-client.c
@@ -696,17 +696,15 @@ server_client_msg_dispatch(struct client *c)
 				fatalx("MSG_IDENTIFY missing fd");
 			memcpy(&identifydata, imsg.data, sizeof identifydata);
 
-			c->stdin_fd = dup(imsg.fd);
-			if (c->stdin_fd == -1)
-				fatal("dup failed");
+			c->stdin_fd = imsg.fd;
 			c->stdin_event = bufferevent_new(c->stdin_fd,
 			    NULL, NULL, server_client_in_callback, c);
 			if (c->stdin_event == NULL)
 				fatalx("failed to create stdin event");
 
-			if ((mode = fcntl(imsg.fd, F_GETFL)) != -1)
-				fcntl(imsg.fd, F_SETFL, mode|O_NONBLOCK);
-			if (fcntl(imsg.fd, F_SETFD, FD_CLOEXEC) == -1)
+			if ((mode = fcntl(c->stdin_fd, F_GETFL)) != -1)
+				fcntl(c->stdin_fd, F_SETFL, mode|O_NONBLOCK);
+			if (fcntl(c->stdin_fd, F_SETFD, FD_CLOEXEC) == -1)
 				fatal("fcntl failed");
 
 			server_client_msg_identify(c, &identifydata, imsg.fd);