summaryrefslogtreecommitdiffstats
path: root/arguments.c
diff options
context:
space:
mode:
authorNicholas Marriott <nicm@openbsd.org>2011-01-30 12:09:30 +0000
committerNicholas Marriott <nicm@openbsd.org>2011-01-30 12:09:30 +0000
commit567741caf57749205d9c190a901430541e5b1fdf (patch)
tree9896e9cef775b803cd4ff3e5899c0abd3ffd0c73 /arguments.c
parent9fc2c34a3b794b6724c1e3fc96f55ee199286c44 (diff)
Free old argument even if setting to NULL.
Diffstat (limited to 'arguments.c')
-rw-r--r--arguments.c9
1 files changed, 5 insertions, 4 deletions
diff --git a/arguments.c b/arguments.c
index ebd09580..97ffec13 100644
--- a/arguments.c
+++ b/arguments.c
@@ -183,11 +183,12 @@ args_has(struct args *args, u_char ch)
void
args_set(struct args *args, u_char ch, const char *value)
{
- if (value != NULL) {
- if (args->values[ch] != NULL)
- xfree(args->values[ch]);
+ if (args->values[ch] != NULL)
+ xfree(args->values[ch]);
+ if (value != NULL)
args->values[ch] = xstrdup(value);
- }
+ else
+ args->values[ch] = NULL;
bit_set(args->flags, ch);
}