summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authornicm <nicm>2023-08-07 10:52:00 +0000
committernicm <nicm>2023-08-07 10:52:00 +0000
commit7b1030293ceade6b17f4b046be0add11755c8602 (patch)
tree395da27dcdf69f3c5f7bfe1c1a31d7a5383cc9e8
parenta5fd80bbc3e6a65ce0e3bce4cf820db3ae0f3165 (diff)
Free title earlier, from Alexis Hildebrandt.
-rw-r--r--cmd-display-menu.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/cmd-display-menu.c b/cmd-display-menu.c
index 4f230ae5..5f9dc459 100644
--- a/cmd-display-menu.c
+++ b/cmd-display-menu.c
@@ -316,6 +316,7 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
else
title = xstrdup("");
menu = menu_create(title);
+ free(title);
for (i = 0; i != count; /* nothing */) {
name = args_string(args, i++);
@@ -326,7 +327,6 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
if (count - i < 2) {
cmdq_error(item, "not enough arguments");
- free(title);
menu_free(menu);
return (CMD_RETURN_ERROR);
}
@@ -338,7 +338,6 @@ cmd_display_menu_exec(struct cmd *self, struct cmdq_item *item)
menu_add_item(menu, &menu_item, item, tc, target);
}
- free(title);
if (menu == NULL) {
cmdq_error(item, "invalid menu arguments");
return (CMD_RETURN_ERROR);