summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorNicholas Marriott <nicm@openbsd.org>2012-04-22 05:21:40 +0000
committerNicholas Marriott <nicm@openbsd.org>2012-04-22 05:21:40 +0000
commite8dff6858815eef50b5ed41c6346cf8d8bb113ee (patch)
treed4e777954d8cdb02f51ab5ee292536b5a64b582d
parentc6e0af9bdb11e2a1d95859725ecedbba31eb3380 (diff)
Handle partial keys properly by making sure the timer has actually
expired, fixes problems with mintty reported by Michael Simpson.
-rw-r--r--tty-keys.c12
1 files changed, 8 insertions, 4 deletions
diff --git a/tty-keys.c b/tty-keys.c
index a9bdaa1c..ddd113e2 100644
--- a/tty-keys.c
+++ b/tty-keys.c
@@ -476,7 +476,6 @@ tty_keys_next(struct tty *tty)
goto partial_key;
}
-
/* Is this a mouse key press? */
switch (tty_keys_mouse(tty, buf, len, &size, &mouse)) {
case 0: /* yes */
@@ -532,10 +531,11 @@ tty_keys_next(struct tty *tty)
partial_key:
/*
- * Escape but no key string. If have already seen an escape, then the
- * timer must have expired, so give up waiting and send the escape.
+ * Escape but no key string. If have already seen an escape and the
+ * timer has expired, give up waiting and send the escape.
*/
- if (tty->flags & TTY_ESCAPE) {
+ if ((tty->flags & TTY_ESCAPE) &&
+ !evtimer_pending(&tty->key_timer, NULL)) {
evbuffer_drain(tty->event->input, 1);
key = '\033';
goto handle_key;
@@ -544,6 +544,10 @@ partial_key:
/* Fall through to start the timer. */
start_timer:
+ /* If already waiting for timer, do nothing. */
+ if (evtimer_pending(&tty->key_timer, NULL))
+ return (0);
+
/* Start the timer and wait for expiry or more data. */
delay = options_get_number(&global_options, "escape-time");
tv.tv_sec = delay / 1000;