If there is an error in the configuration file, don't just exit(1) as this can

cause the client to hang. Instead, send the error message, then mark the client
as bad and start a normal shutdown so the server exits once the error is
written.

This also allows some code duplicating daemon(3) to be trimmed and logging to
begin earlier.

Prompted by Theo noticing the behaviour on error wasn't documented.

1 files changed, 2 insertions, 0 deletions

diff --git a/server-fn.c b/server-fn.c
index 8a4b1f1d..83ef6ca8 100644
--- a/server-fn.c
+++ b/server-fn.c
@@ -62,6 +62,8 @@ server_write_client(
 {
 	struct hdr	 hdr;
 
+	if (c->flags & CLIENT_BAD)
+		return;
 	log_debug("writing %d to client %d", type, c->fd);
 
 	hdr.type = type;