summaryrefslogtreecommitdiffstats
path: root/cmd-swap-pane.c
diff options
context:
space:
mode:
authorTiago Cunha <tcunha@gmx.com>2009-07-28 22:12:16 +0000
committerTiago Cunha <tcunha@gmx.com>2009-07-28 22:12:16 +0000
commitd637cb33da212a74636984be0ce9dfface6be6b4 (patch)
tree414de53bc14b91edcda17ee2cb99cf081440a2de /cmd-swap-pane.c
parentf5c0695605f65b7b8d0c41e0816186e979c3e130 (diff)
Sync OpenBSD patchset 181:
Make all messages sent between the client and server fixed size. This is the first of two changes to make the protocol more resilient and less sensitive to other changes in the code, particularly with commands. The client now packs argv into a buffer and sends it to the server for parsing, rather than doing it itself and sending the parsed command data. As a side-effect this also removes a lot of now-unused command marshalling code. Mixing a server without this change and a client with or vice versa will cause tmux to hang or crash, please ensure that tmux is entirely killed before upgrading.
Diffstat (limited to 'cmd-swap-pane.c')
-rw-r--r--cmd-swap-pane.c25
1 files changed, 1 insertions, 24 deletions
diff --git a/cmd-swap-pane.c b/cmd-swap-pane.c
index 1b457538..b6847fca 100644
--- a/cmd-swap-pane.c
+++ b/cmd-swap-pane.c
@@ -1,4 +1,4 @@
-/* $Id: cmd-swap-pane.c,v 1.10 2009-07-20 15:48:54 tcunha Exp $ */
+/* $Id: cmd-swap-pane.c,v 1.11 2009-07-28 22:12:16 tcunha Exp $ */
/*
* Copyright (c) 2009 Nicholas Marriott <nicm@users.sourceforge.net>
@@ -28,8 +28,6 @@
int cmd_swap_pane_parse(struct cmd *, int, char **, char **);
int cmd_swap_pane_exec(struct cmd *, struct cmd_ctx *);
-void cmd_swap_pane_send(struct cmd *, struct buffer *);
-void cmd_swap_pane_recv(struct cmd *, struct buffer *);
void cmd_swap_pane_free(struct cmd *);
void cmd_swap_pane_init(struct cmd *, int);
size_t cmd_swap_pane_print(struct cmd *, char *, size_t);
@@ -50,8 +48,6 @@ const struct cmd_entry cmd_swap_pane_entry = {
cmd_swap_pane_init,
cmd_swap_pane_parse,
cmd_swap_pane_exec,
- cmd_swap_pane_send,
- cmd_swap_pane_recv,
cmd_swap_pane_free,
cmd_swap_pane_print
};
@@ -235,25 +231,6 @@ cmd_swap_pane_exec(struct cmd *self, struct cmd_ctx *ctx)
}
void
-cmd_swap_pane_send(struct cmd *self, struct buffer *b)
-{
- struct cmd_swap_pane_data *data = self->data;
-
- buffer_write(b, data, sizeof *data);
- cmd_send_string(b, data->target);
-}
-
-void
-cmd_swap_pane_recv(struct cmd *self, struct buffer *b)
-{
- struct cmd_swap_pane_data *data;
-
- self->data = data = xmalloc(sizeof *data);
- buffer_read(b, data, sizeof *data);
- data->target = cmd_recv_string(b);
-}
-
-void
cmd_swap_pane_free(struct cmd *self)
{
struct cmd_swap_pane_data *data = self->data;