diff options
| author | Nicholas Marriott <nicm@openbsd.org> | 2009-11-26 21:14:30 +0000 |
|---|---|---|
| committer | Nicholas Marriott <nicm@openbsd.org> | 2009-11-26 21:14:30 +0000 |
| commit | 3e147967e2197accb2549c6b57ffb392030616d8 (patch) | |
| tree | 693fea88abc67dd45e39e6fb34a0727f97cb3831 /cmd-string.c | |
| parent | 9c0147915e3724af59f718ef11936ad319c54c54 (diff) | |
Get a u_char from the string, otherwise it isn't possible to enter \0377 as it
is mistaken for EOF (doh).
Also drop an unused argument.
Diffstat (limited to 'cmd-string.c')
| -rw-r--r-- | cmd-string.c | 14 |
1 files changed, 8 insertions, 6 deletions
diff --git a/cmd-string.c b/cmd-string.c index 9cb48466..8e2ec1bf 100644 --- a/cmd-string.c +++ b/cmd-string.c @@ -32,7 +32,7 @@ */ int cmd_string_getc(const char *, size_t *); -void cmd_string_ungetc(const char *, size_t *); +void cmd_string_ungetc(size_t *); char *cmd_string_string(const char *, size_t *, char, int); char *cmd_string_variable(const char *, size_t *); char *cmd_string_expand_tilde(const char *, size_t *); @@ -40,13 +40,15 @@ char *cmd_string_expand_tilde(const char *, size_t *); int cmd_string_getc(const char *s, size_t *p) { - if (s[*p] == '\0') + const u_char *ucs = s; + + if (ucs[*p] == '\0') return (EOF); - return (s[(*p)++]); + return (ucs[(*p)++]); } void -cmd_string_ungetc(unused const char *s, size_t *p) +cmd_string_ungetc(size_t *p) { (*p)--; } @@ -306,7 +308,7 @@ cmd_string_variable(const char *s, size_t *p) if (fch == '{' && ch != '}') goto error; if (ch != EOF && fch != '{') - cmd_string_ungetc(s, p); /* ch */ + cmd_string_ungetc(p); /* ch */ buf = xrealloc(buf, 1, len + 1); buf[len] = '\0'; @@ -337,7 +339,7 @@ cmd_string_expand_tilde(const char *s, size_t *p) home = pw->pw_dir; } } else { - cmd_string_ungetc(s, p); + cmd_string_ungetc(p); if ((username = cmd_string_string(s, p, '/', 0)) == NULL) return (NULL); if ((pw = getpwnam(username)) != NULL) |