diff options
| author | Kevin Song <chips@ksong.dev> | 2022-03-10 11:40:43 -0600 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-03-10 11:40:43 -0600 |
| commit | ef967271e6009d3515fdd4c3dd64f575676411a9 (patch) | |
| tree | 76aa8326b49831b7a90dbbf4cde070c37a4d8f58 | |
| parent | a85f65473d6f11be504e48299c449b16150f2511 (diff) | |
fix(install): Add -o flag to unzip to match tar (#3727)
By default, unzip will attempt to query the user when files to be
installed already exist. Unfortunately, if the install script is run
with `sh -s`, unzip will read the remaining portion of the script as
input, resulting in a mess on the terminal.
This commit changes the unzip behavior to clobber existing files: this
already happens for platforms using tar, so it's not hugely breaking
(and I could find no evidence that we believe this is more likely to
cause issues on Windows)
| -rwxr-xr-x | install/install.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/install/install.sh b/install/install.sh index 6936ba7ba..1cd2028c7 100755 --- a/install/install.sh +++ b/install/install.sh @@ -116,7 +116,7 @@ unpack() { return 0 ;; *.zip) - flags=$(test -z "${VERBOSE-}" && echo "-qq" || echo "") + flags=$(test -z "${VERBOSE-}" && echo "-qqo" || echo "-o") UNZIP="${flags}" ${sudo} unzip "${archive}" -d "${bin_dir}" return 0 ;; |