summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVidar Holen <vidar@vidarholen.net>2024-04-07 13:27:14 -0700
committerGitHub <noreply@github.com>2024-04-07 13:27:14 -0700
commit79491db9f679167ee346c149448a0f66062c74af (patch)
tree2b3b89f98bbfcc82f58b2707b8fa38901448e0fc
parent5241878e5919d3581a8e0208c3d2345532dbb65f (diff)
parent9cb21c8557cb981e5f49da20af9335bb68f04dee (diff)
Merge pull request #2938 from larryv/reword-SC2324
Recommend `typeset` instead of `declare` in SC2324
-rw-r--r--src/ShellCheck/Analytics.hs3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/ShellCheck/Analytics.hs b/src/ShellCheck/Analytics.hs
index 1cc8bf8..f37ac1d 100644
--- a/src/ShellCheck/Analytics.hs
+++ b/src/ShellCheck/Analytics.hs
@@ -5017,7 +5017,8 @@ checkPlusEqualsNumber params t =
state <- CF.getIncomingState cfga id
guard $ isNumber state word
guard . not $ fromMaybe False $ CF.variableMayBeDeclaredInteger state var
- return $ warn id 2324 "var+=1 will append, not increment. Use (( var += 1 )), declare -i var, or quote number to silence."
+ -- Recommend "typeset" because ksh does not have "declare".
+ return $ warn id 2324 "var+=1 will append, not increment. Use (( var += 1 )), typeset -i var, or quote number to silence."
_ -> return ()
where