diff options
Diffstat (limited to 'apps/lib')
| -rw-r--r-- | apps/lib/apps.c | 3 | ||||
| -rw-r--r-- | apps/lib/cmp_mock_srv.c | 2 | ||||
| -rw-r--r-- | apps/lib/http_server.c | 1 |
3 files changed, 0 insertions, 6 deletions
diff --git a/apps/lib/apps.c b/apps/lib/apps.c index 12a17fceed..3d6588ba23 100644 --- a/apps/lib/apps.c +++ b/apps/lib/apps.c @@ -885,7 +885,6 @@ int load_key_certs_crls(const char *uri, int format, int maybe_stdin, const char *input_type; OSSL_PARAM itp[2]; const OSSL_PARAM *params = NULL; - /* TODO make use of the engine reference 'eng' when loading pkeys */ if (ppkey != NULL) { *ppkey = NULL; @@ -2258,8 +2257,6 @@ int do_X509_sign(X509 *cert, EVP_PKEY *pkey, const char *md, if (!adapt_keyid_ext(cert, ext_ctx, "authorityKeyIdentifier", "keyid, issuer", !self_sign)) goto end; - - /* TODO any further measures for ensuring default RFC 5280 compliance */ } if (mctx != NULL && do_sign_init(mctx, pkey, md, sigopts) > 0) diff --git a/apps/lib/cmp_mock_srv.c b/apps/lib/cmp_mock_srv.c index 1e6a27210c..1caaa2f0eb 100644 --- a/apps/lib/cmp_mock_srv.c +++ b/apps/lib/cmp_mock_srv.c @@ -204,7 +204,6 @@ static OSSL_CMP_PKISI *process_cert_request(OSSL_CMP_SRV_CTX *srv_ctx, } if (ctx->certOut != NULL && (*certOut = X509_dup(ctx->certOut)) == NULL) - /* TODO better return a cert produced from data in request template */ goto err; if (ctx->chainOut != NULL && (*chainOut = X509_chain_up_ref(ctx->chainOut)) == NULL) @@ -312,7 +311,6 @@ static void process_error(OSSL_CMP_SRV_CTX *srv_ctx, const OSSL_CMP_MSG *error, if (sk_ASN1_UTF8STRING_num(errorDetails) <= 0) { BIO_printf(bio_err, "errorDetails absent\n"); } else { - /* TODO could use sk_ASN1_UTF8STRING2text() if exported */ BIO_printf(bio_err, "errorDetails: "); for (i = 0; i < sk_ASN1_UTF8STRING_num(errorDetails); i++) { if (i > 0) diff --git a/apps/lib/http_server.c b/apps/lib/http_server.c index 46065d2dd0..1858d04ccb 100644 --- a/apps/lib/http_server.c +++ b/apps/lib/http_server.c @@ -405,7 +405,6 @@ int http_server_get_asn1_req(const ASN1_ITEM *it, ASN1_VALUE **preq, log_message(prog, LOG_WARNING, "HTTP request does not begin with %sPOST: %s", accept_get ? "GET or " : "", reqbuf); - /* TODO provide better diagnosis in case client tries TLS */ (void)http_server_send_status(cbio, 400, "Bad Request"); goto out; } |