diff options
| -rw-r--r-- | crypto/dsa/dsa_gen.c | 8 | ||||
| -rw-r--r-- | doc/crypto/DSA_generate_parameters.pod | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/crypto/dsa/dsa_gen.c b/crypto/dsa/dsa_gen.c index 847c874ad2..f65790c58c 100644 --- a/crypto/dsa/dsa_gen.c +++ b/crypto/dsa/dsa_gen.c @@ -167,7 +167,7 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, if (seed_len < (size_t)qsize) return 0; if (seed_len > (size_t)qsize) { - /* Don't overflow seed local variable. */ + /* Only consume as much seed as is expected. */ seed_len = qsize; } memcpy(seed, seed_in, seed_len); @@ -194,13 +194,13 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, for (;;) { for (;;) { /* find q */ - int seed_is_random = seed_in == NULL; + int use_random_seed = (seed_in == NULL); /* step 1 */ if (!BN_GENCB_call(cb, 0, m++)) goto err; - if (seed_is_random) { + if (use_random_seed) { if (RAND_bytes(seed, qsize) <= 0) goto err; } else { @@ -232,7 +232,7 @@ int dsa_builtin_paramgen(DSA *ret, size_t bits, size_t qbits, /* step 4 */ r = BN_is_prime_fasttest_ex(q, DSS_prime_checks, ctx, - seed_is_random, cb); + use_random_seed, cb); if (r > 0) break; if (r != 0) diff --git a/doc/crypto/DSA_generate_parameters.pod b/doc/crypto/DSA_generate_parameters.pod index 7db1522d63..116ff096a0 100644 --- a/doc/crypto/DSA_generate_parameters.pod +++ b/doc/crypto/DSA_generate_parameters.pod @@ -25,7 +25,7 @@ for use in the DSA and stores the result in B<dsa>. B<bits> is the length of the prime p to be generated. For lengths under 2048 bits, the length of q is 160 bits; for lengths -at least 2048, it is set to 256 bits. +greater than or equal to 2048 bits, the length of q is set to 256 bits. If B<seed> is NULL, the primes will be generated at random. If B<seed_len> is less than the length of q, an error is returned. |