diff options
author | Matthias St. Pierre <matthias.st.pierre@ncp-e.com> | 2023-10-16 01:35:48 +0200 |
---|---|---|
committer | Matt Caswell <matt@openssl.org> | 2023-10-24 11:19:04 +0100 |
commit | 380ae1b3ac7052f873099dcccd9c378f64e11fc1 (patch) | |
tree | b2ee3e471bb265a3310355c5392487acae602042 /test/helpers/predefined_dhparams.c | |
parent | bb9615930882fd9b6677c27a01446f38e417ddcd (diff) |
rand: fix seeding from a weak entropy source
The 'rand_generate' method is not well suited for being used with
weak entropy sources in the 'get_entropy' callback, because the
caller needs to provide a preallocated buffer without knowing
how much bytes are actually needed to collect the required entropy.
Instead we use the 'rand_get_seed' and 'rand_clear_seed' methods
which were exactly designed for this purpose: it's the callee who
allocates and fills the buffer, and finally cleans it up again.
The 'rand_get_seed' and 'rand_clear_seed' methods are currently
optional for a provided random generator. We could fall back to
using 'rand_generate' if those methods are not implemented.
However, imo it would be better to simply make them an officially
documented requirement for seed sources.
Fixes #22332
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22394)
(cherry picked from commit 7998e7dc07d8f1f516af32887f2490c03cd8c594)
Diffstat (limited to 'test/helpers/predefined_dhparams.c')
0 files changed, 0 insertions, 0 deletions