diff options
author | Pauli <ppzgs1@gmail.com> | 2021-03-19 10:17:11 +1000 |
---|---|---|
committer | Pauli <pauli@openssl.org> | 2021-03-26 08:44:04 +1000 |
commit | 993237a8b678a888c05bc88d6c872be74696b768 (patch) | |
tree | a64054c052a2fda45ea640ef53dba0f48cb92e47 /providers/implementations | |
parent | 8f4cddbc903a402abb9f39c2e220ee3858188655 (diff) |
rsa: fix coverity 1463571: explicit null dereference
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14618)
Diffstat (limited to 'providers/implementations')
-rw-r--r-- | providers/implementations/keymgmt/rsa_kmgmt.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/providers/implementations/keymgmt/rsa_kmgmt.c b/providers/implementations/keymgmt/rsa_kmgmt.c index 394f3836dd..eac3843884 100644 --- a/providers/implementations/keymgmt/rsa_kmgmt.c +++ b/providers/implementations/keymgmt/rsa_kmgmt.c @@ -435,16 +435,15 @@ static void *gen_init(void *provctx, int selection, int rsa_type, || !BN_set_word(gctx->pub_exp, RSA_F4)) { BN_free(gctx->pub_exp); OPENSSL_free(gctx); - gctx = NULL; - } else { - gctx->nbits = 2048; - gctx->primes = RSA_DEFAULT_PRIME_NUM; - gctx->rsa_type = rsa_type; + return NULL; } + gctx->nbits = 2048; + gctx->primes = RSA_DEFAULT_PRIME_NUM; + gctx->rsa_type = rsa_type; } if (!rsa_gen_set_params(gctx, params)) { OPENSSL_free(gctx); - gctx = NULL; + return NULL; } return gctx; } |