summaryrefslogtreecommitdiffstats
path: root/crypto
diff options
context:
space:
mode:
authorRichard Levitte <levitte@openssl.org>2022-01-11 18:27:23 +0100
committerRichard Levitte <levitte@openssl.org>2022-01-21 14:44:16 +0100
commitfbe88706a4f93f9e1940a07062d77c81b7fdf04d (patch)
treebef458b65aacff2a474404ab8269f004629dee87 /crypto
parentf59d72f027da90edcccad5cc78c94d3099fadecf (diff)
ERR: Move ERR_set_mark(), ERR_pop_to_mark() and ERR_clear_last_mark()
Move them to their own source file, so they end up in a separate object file. This allows providers to override their implementation to use the corresponding OSSL_FUNC upcalls without having to reimplement everything from crypto/err/err.c. Reviewed-by: Paul Dale <pauli@openssl.org> (Merged from https://github.com/openssl/openssl/pull/17474)
Diffstat (limited to 'crypto')
-rw-r--r--crypto/err/build.info2
-rw-r--r--crypto/err/err.c55
-rw-r--r--crypto/err/err_mark.c69
3 files changed, 70 insertions, 56 deletions
diff --git a/crypto/err/build.info b/crypto/err/build.info
index 98f8801e34..ee37938418 100644
--- a/crypto/err/build.info
+++ b/crypto/err/build.info
@@ -1,3 +1,3 @@
LIBS=../../libcrypto
SOURCE[../../libcrypto]=\
- err_blocks.c err.c err_all.c err_all_legacy.c err_prn.c
+ err_blocks.c err_mark.c err.c err_all.c err_all_legacy.c err_prn.c
diff --git a/crypto/err/err.c b/crypto/err/err.c
index 59ca4114db..63cf682382 100644
--- a/crypto/err/err.c
+++ b/crypto/err/err.c
@@ -847,61 +847,6 @@ void ERR_add_error_vdata(int num, va_list args)
OPENSSL_free(str);
}
-int ERR_set_mark(void)
-{
- ERR_STATE *es;
-
- es = ossl_err_get_state_int();
- if (es == NULL)
- return 0;
-
- if (es->bottom == es->top)
- return 0;
- es->err_marks[es->top]++;
- return 1;
-}
-
-int ERR_pop_to_mark(void)
-{
- ERR_STATE *es;
-
- es = ossl_err_get_state_int();
- if (es == NULL)
- return 0;
-
- while (es->bottom != es->top
- && es->err_marks[es->top] == 0) {
- err_clear(es, es->top, 0);
- es->top = es->top > 0 ? es->top - 1 : ERR_NUM_ERRORS - 1;
- }
-
- if (es->bottom == es->top)
- return 0;
- es->err_marks[es->top]--;
- return 1;
-}
-
-int ERR_clear_last_mark(void)
-{
- ERR_STATE *es;
- int top;
-
- es = ossl_err_get_state_int();
- if (es == NULL)
- return 0;
-
- top = es->top;
- while (es->bottom != top
- && es->err_marks[top] == 0) {
- top = top > 0 ? top - 1 : ERR_NUM_ERRORS - 1;
- }
-
- if (es->bottom == top)
- return 0;
- es->err_marks[top]--;
- return 1;
-}
-
void err_clear_last_constant_time(int clear)
{
ERR_STATE *es;
diff --git a/crypto/err/err_mark.c b/crypto/err/err_mark.c
new file mode 100644
index 0000000000..cc1baba7a3
--- /dev/null
+++ b/crypto/err/err_mark.c
@@ -0,0 +1,69 @@
+/*
+ * Copyright 2003-2022 The OpenSSL Project Authors. All Rights Reserved.
+ *
+ * Licensed under the Apache License 2.0 (the "License"). You may not use
+ * this file except in compliance with the License. You can obtain a copy
+ * in the file LICENSE in the source distribution or at
+ * https://www.openssl.org/source/license.html
+ */
+
+#define OSSL_FORCE_ERR_STATE
+
+#include <openssl/err.h>
+#include "err_local.h"
+
+int ERR_set_mark(void)
+{
+ ERR_STATE *es;
+
+ es = ossl_err_get_state_int();
+ if (es == NULL)
+ return 0;
+
+ if (es->bottom == es->top)
+ return 0;
+ es->err_marks[es->top]++;
+ return 1;
+}
+
+int ERR_pop_to_mark(void)
+{
+ ERR_STATE *es;
+
+ es = ossl_err_get_state_int();
+ if (es == NULL)
+ return 0;
+
+ while (es->bottom != es->top
+ && es->err_marks[es->top] == 0) {
+ err_clear(es, es->top, 0);
+ es->top = es->top > 0 ? es->top - 1 : ERR_NUM_ERRORS - 1;
+ }
+
+ if (es->bottom == es->top)
+ return 0;
+ es->err_marks[es->top]--;
+ return 1;
+}
+
+int ERR_clear_last_mark(void)
+{
+ ERR_STATE *es;
+ int top;
+
+ es = ossl_err_get_state_int();
+ if (es == NULL)
+ return 0;
+
+ top = es->top;
+ while (es->bottom != top
+ && es->err_marks[top] == 0) {
+ top = top > 0 ? top - 1 : ERR_NUM_ERRORS - 1;
+ }
+
+ if (es->bottom == top)
+ return 0;
+ es->err_marks[top]--;
+ return 1;
+}
+