diff options
| author | Geoff Thorpe <geoff@openssl.org> | 2004-03-13 22:10:15 +0000 |
|---|---|---|
| committer | Geoff Thorpe <geoff@openssl.org> | 2004-03-13 22:10:15 +0000 |
| commit | 9e051bac139ce07f846d88b90f3ec514c39ea416 (patch) | |
| tree | 234a4800454556d58354140cd9d1ced9a56f9478 /crypto | |
| parent | 30fbcaa213866426c9f6b9dad01b9885ab760e31 (diff) | |
Document a change I'd already made, and at the same time, correct the
change to work properly; BN_zero() should set 'neg' to zero as well as
'top' to match the behaviour of BN_new().
Diffstat (limited to 'crypto')
| -rw-r--r-- | crypto/bn/bn_ctx.c | 6 | ||||
| -rw-r--r-- | crypto/bn/bn_div.c | 1 |
2 files changed, 4 insertions, 3 deletions
diff --git a/crypto/bn/bn_ctx.c b/crypto/bn/bn_ctx.c index 9366ce6d7f..f48055b268 100644 --- a/crypto/bn/bn_ctx.c +++ b/crypto/bn/bn_ctx.c @@ -140,6 +140,7 @@ void BN_CTX_start(BN_CTX *ctx) BIGNUM *BN_CTX_get(BN_CTX *ctx) { + BIGNUM *ret; /* Note: If BN_CTX_get is ever changed to allocate BIGNUMs dynamically, * make sure that if BN_CTX_get fails once it will return NULL again * until BN_CTX_end is called. (This is so that callers have to check @@ -155,9 +156,10 @@ BIGNUM *BN_CTX_get(BN_CTX *ctx) } return NULL; } + ret = ctx->bn + (ctx->tos++); /* always return a 'zeroed' bignum */ - ctx->bn[ctx->tos].top = 0; - return (&(ctx->bn[ctx->tos++])); + BN_zero(ret); + return ret; } void BN_CTX_end(BN_CTX *ctx) diff --git a/crypto/bn/bn_div.c b/crypto/bn/bn_div.c index 556fcda1e3..3b4392955e 100644 --- a/crypto/bn/bn_div.c +++ b/crypto/bn/bn_div.c @@ -214,7 +214,6 @@ int BN_div(BIGNUM *dv, BIGNUM *rm, const BIGNUM *num, const BIGNUM *divisor, res=BN_CTX_get(ctx); else res=dv; if (sdiv == NULL || res == NULL) goto err; - tmp->neg=0; /* First we normalise the numbers */ norm_shift=BN_BITS2-((BN_num_bits(divisor))%BN_BITS2); |