summaryrefslogtreecommitdiffstats
path: root/crypto/x509/x509_obj.c
diff options
context:
space:
mode:
authorMatt Caswell <matt@openssl.org>2016-05-17 11:07:27 +0100
committerMatt Caswell <matt@openssl.org>2016-05-17 14:27:59 +0100
commit57f115e9088fafdc8a65bdf709e9154dded4ab10 (patch)
tree169207d595e7a4ca90f20b9454192c10f3ec91f2 /crypto/x509/x509_obj.c
parenta79a40a9fe136b63f19b6756cd2a3ce6bd170f54 (diff)
Remove repeated condition from if in X509_NAME_oneline
An if checks the value of |type| to see if it is V_ASN1_VISIBLESTRING twice. We only need to do it once. GitHub Issue #656 Reviewed-by: Richard Levitte <levitte@openssl.org> (cherry picked from commit 2647e2617e31002cb0ab80758be4e566917d2888)
Diffstat (limited to 'crypto/x509/x509_obj.c')
-rw-r--r--crypto/x509/x509_obj.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/crypto/x509/x509_obj.c b/crypto/x509/x509_obj.c
index 3de3ac7204..0a839f3e54 100644
--- a/crypto/x509/x509_obj.c
+++ b/crypto/x509/x509_obj.c
@@ -129,7 +129,7 @@ char *X509_NAME_oneline(X509_NAME *a, char *buf, int len)
type == V_ASN1_VISIBLESTRING ||
type == V_ASN1_PRINTABLESTRING ||
type == V_ASN1_TELETEXSTRING ||
- type == V_ASN1_VISIBLESTRING || type == V_ASN1_IA5STRING) {
+ type == V_ASN1_IA5STRING) {
if (num > (int)sizeof(ebcdic_buf))
num = sizeof(ebcdic_buf);
ascii2ebcdic(ebcdic_buf, q, num);