diff options
| author | David Benjamin <davidben@google.com> | 2020-02-17 12:17:53 +1000 |
|---|---|---|
| committer | Pauli <paul.dale@oracle.com> | 2020-02-17 12:17:53 +1000 |
| commit | a21314dbbc56cd30580123d74b3106a628540965 (patch) | |
| tree | 18e881206ce27d0121ae9da0530ea76a2856bfe2 /crypto/perlasm | |
| parent | 0eb154663478968137112441d16b593fdf2ebcf8 (diff) | |
Also check for errors in x86_64-xlate.pl.
In https://github.com/openssl/openssl/pull/10883, I'd meant to exclude
the perlasm drivers since they aren't opening pipes and do not
particularly need it, but I only noticed x86_64-xlate.pl, so
arm-xlate.pl and ppc-xlate.pl got the change.
That seems to have been fine, so be consistent and also apply the change
to x86_64-xlate.pl. Checking for errors is generally a good idea.
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: David Benjamin <davidben@google.com>
(Merged from https://github.com/openssl/openssl/pull/10930)
Diffstat (limited to 'crypto/perlasm')
| -rwxr-xr-x | crypto/perlasm/arm-xlate.pl | 2 | ||||
| -rwxr-xr-x | crypto/perlasm/ppc-xlate.pl | 2 | ||||
| -rwxr-xr-x | crypto/perlasm/x86_64-xlate.pl | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/crypto/perlasm/arm-xlate.pl b/crypto/perlasm/arm-xlate.pl index bee0523fef..b7ee99ee94 100755 --- a/crypto/perlasm/arm-xlate.pl +++ b/crypto/perlasm/arm-xlate.pl @@ -191,4 +191,4 @@ while(my $line=<>) { print "\n"; } -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/perlasm/ppc-xlate.pl b/crypto/perlasm/ppc-xlate.pl index 330510109c..571d59c2ea 100755 --- a/crypto/perlasm/ppc-xlate.pl +++ b/crypto/perlasm/ppc-xlate.pl @@ -343,4 +343,4 @@ while($line=<>) { print "\n"; } -close STDOUT or die "error closing STDOUT"; +close STDOUT or die "error closing STDOUT: $!"; diff --git a/crypto/perlasm/x86_64-xlate.pl b/crypto/perlasm/x86_64-xlate.pl index 7a282109ef..aff165c5fa 100755 --- a/crypto/perlasm/x86_64-xlate.pl +++ b/crypto/perlasm/x86_64-xlate.pl @@ -1244,7 +1244,7 @@ print "$cet_property" if ($cet_property); print "\n$current_segment\tENDS\n" if ($current_segment && $masm); print "END\n" if ($masm); -close STDOUT; +close STDOUT or die "error closing STDOUT: $!;" ################################################# # Cross-reference x86_64 ABI "card" |