diff options
author | Richard Levitte <levitte@openssl.org> | 2002-02-20 11:57:33 +0000 |
---|---|---|
committer | Richard Levitte <levitte@openssl.org> | 2002-02-20 11:57:33 +0000 |
commit | 4b71f63ac0de0df0ec321b0522a30e8d3e356760 (patch) | |
tree | dead9ccb47d73768dd3d010a3b79cec914ff392f /crypto/ecdsa | |
parent | 3adb8c385404448629465cdf02fe1431b8e0e160 (diff) |
Comparing a pointer (data) with 0 using > is incorrect. The changed
comparison doesn't look right, but at least it compiles. It would be nice
if the one who knows what this is supposed to do changed it to do it correctly
Diffstat (limited to 'crypto/ecdsa')
-rw-r--r-- | crypto/ecdsa/ecs_asn1.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/crypto/ecdsa/ecs_asn1.c b/crypto/ecdsa/ecs_asn1.c index b3bdd4e5fb..542a987bc2 100644 --- a/crypto/ecdsa/ecs_asn1.c +++ b/crypto/ecdsa/ecs_asn1.c @@ -439,7 +439,9 @@ ECDSA *ECDSA_x9_62parameters2ecdsa(const X9_62_EC_PARAMETERS *params, EC if ((point = EC_POINT_new(ret->group)) == NULL) goto err; } else OPENSSL_ECDSA_ABORT(ECDSA_R_WRONG_FIELD_IDENTIFIER) - if (params->curve->seed != NULL && params->curve->seed->data > 0) + /* FIXME!!! It seems like the comparison of data with 0 isn't the + intended thing. */ + if (params->curve->seed != NULL && params->curve->seed->data != 0) { if (ret->seed != NULL) OPENSSL_free(ret->seed); |