diff options
| author | Pauli <pauli@openssl.org> | 2022-03-16 14:13:25 +1100 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2022-03-25 17:32:10 +1100 |
| commit | 8ae3d248ad25fb986b30b67de72b4006869c8965 (patch) | |
| tree | a864d3e4cd2f2dad322ede13c75cd84c4728f3ae /crypto/ec | |
| parent | ef8312480e5c21495f43740b8522459aa8cf9a79 (diff) | |
Fix Coverity 1498612: integer overflow
The assert added cannot ever fail because (current & 0xFFFF) != 0 from the
while loop and the trailing zero bit count therefore cannot be as large as 32.
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
(Merged from https://github.com/openssl/openssl/pull/17892)
(cherry picked from commit 81487b65b9eb8148471e729b8c1959521d62c69e)
Diffstat (limited to 'crypto/ec')
| -rw-r--r-- | crypto/ec/curve448/curve448.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/crypto/ec/curve448/curve448.c b/crypto/ec/curve448/curve448.c index 9b9786da8f..4db72cd28d 100644 --- a/crypto/ec/curve448/curve448.c +++ b/crypto/ec/curve448/curve448.c @@ -586,6 +586,7 @@ static int recode_wnaf(struct smvt_control *control, int32_t delta = odd & mask; assert(position >= 0); + assert(pos < 32); /* can't fail since current & 0xFFFF != 0 */ if (odd & (1 << (table_bits + 1))) delta -= (1 << (table_bits + 1)); current -= delta * (1 << pos); |