diff options
| author | David Benjamin <davidben@google.com> | 2019-01-29 05:12:15 +0000 |
|---|---|---|
| committer | Kurt Roeckx <kurt@roeckx.be> | 2019-02-17 23:39:51 +0100 |
| commit | c0e8e5007ba5234d4d448e82a1567e0c4467e629 (patch) | |
| tree | 257257043dcf4b59cca63acde207333d8ddbac26 /crypto/bn/asm/x86_64-mont5.pl | |
| parent | 8f58ede09572dcc6a7e6c01280dd348240199568 (diff) | |
Fix some CFI issues in x86_64 assembly
The add/double shortcut in ecp_nistz256-x86_64.pl left one instruction
point that did not unwind, and the "slow" path in AES_cbc_encrypt was
not annotated correctly. For the latter, add
.cfi_{remember,restore}_state support to perlasm.
Next, fill in a bunch of functions that are missing no-op .cfi_startproc
and .cfi_endproc blocks. libunwind cannot unwind those stack frames
otherwise.
Finally, work around a bug in libunwind by not encoding rflags. (rflags
isn't a callee-saved register, so there's not much need to annotate it
anyway.)
These were found as part of ABI testing work in BoringSSL.
Reviewed-by: Richard Levitte <levitte@openssl.org>
GH: #8109
Diffstat (limited to 'crypto/bn/asm/x86_64-mont5.pl')
| -rwxr-xr-x | crypto/bn/asm/x86_64-mont5.pl | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/crypto/bn/asm/x86_64-mont5.pl b/crypto/bn/asm/x86_64-mont5.pl index 8fa233ca12..6331566c0c 100755 --- a/crypto/bn/asm/x86_64-mont5.pl +++ b/crypto/bn/asm/x86_64-mont5.pl @@ -2910,6 +2910,7 @@ bn_powerx5: .align 32 bn_sqrx8x_internal: __bn_sqrx8x_internal: +.cfi_startproc ################################################################## # Squaring part: # @@ -3542,6 +3543,7 @@ __bn_sqrx8x_reduction: cmp 8+8(%rsp),%r8 # end of t[]? jb .Lsqrx8x_reduction_loop ret +.cfi_endproc .size bn_sqrx8x_internal,.-bn_sqrx8x_internal ___ } |