diff options
author | FdaSilvaYY <fdasilvayy@gmail.com> | 2016-11-16 22:46:25 +0100 |
---|---|---|
committer | Matt Caswell <matt@openssl.org> | 2017-01-23 14:32:52 +0000 |
commit | 45789c2819e1cb93150061ddaa95fe97da2c0cba (patch) | |
tree | e65f78881b05a1b1de1ac0c97ad78691d40b0999 /apps | |
parent | c4fec137617c2002f6f8a76981a47ab79908f628 (diff) |
Fix use before assignment
it was getting the SerialNumber of a previous cert.
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/2272)
(cherry picked from commit 0db1fb3fc13c4b1a2b916efbb374f40579b1398f)
Diffstat (limited to 'apps')
-rw-r--r-- | apps/ca.c | 9 |
1 files changed, 4 insertions, 5 deletions
@@ -983,12 +983,11 @@ end_of_options: BIO_printf(bio_err, "writing new certificates\n"); for (i = 0; i < sk_X509_num(cert_sk); i++) { BIO *Cout = NULL; - ASN1_INTEGER *serialNumber = X509_get_serialNumber(x); + X509 *xi = sk_X509_value(cert_sk, i); + ASN1_INTEGER *serialNumber = X509_get_serialNumber(xi); int k; char *n; - x = sk_X509_value(cert_sk, i); - j = ASN1_STRING_length(serialNumber); p = (const char *)ASN1_STRING_get0_data(serialNumber); @@ -1030,8 +1029,8 @@ end_of_options: perror(buf[2]); goto end; } - write_new_certificate(Cout, x, 0, notext); - write_new_certificate(Sout, x, output_der, notext); + write_new_certificate(Cout, xi, 0, notext); + write_new_certificate(Sout, xi, output_der, notext); BIO_free_all(Cout); } |