summaryrefslogtreecommitdiffstats
path: root/apps/ocsp.c
diff options
context:
space:
mode:
authorShane Lontis <shane.lontis@oracle.com>2020-02-04 13:50:51 +1000
committerShane Lontis <shane.lontis@oracle.com>2020-02-04 13:50:51 +1000
commitd5e66eab0bc08d701ba8386d3a36d417d19966aa (patch)
treeef8de7ba3180d40dcdf4f0f73df80e25c42f57d4 /apps/ocsp.c
parent450d12c825cc9016e5e8990423fa7ffdb843a1f0 (diff)
Fix coverity issues CID 1457745...1457752, 1457853, 1457854
CID 1457854 - keymgmt_lib.c : OVERRUN CID 1457853 - self_test_kats.c : UNINT CID 1457752 - fipsprov.c RESOURCE_LEAK (code change in another PR removed this) CID 1457751 - apps/pkcs12.c CHECKED_RETURN CID 1457750 - dsa_ossl.c RESOURCE_LEAK (marked as false positive since tmp can not be NULL) CID 1457749 - apps/nseq.c : CHECKED_RETURN CID 1457748 - cipher_aes_cbc_hmac_sha.c : SIZEOF_MISMATCH CID 1457747 - cipher_aes_cbc_hmac_sha.c : SIZEOF_MISMATCH CID 1457746 - same as 1457752 CID 1457745 - apps/ocsp : CHECKED_RETURN Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/10934)
Diffstat (limited to 'apps/ocsp.c')
-rw-r--r--apps/ocsp.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/apps/ocsp.c b/apps/ocsp.c
index dc1b7601bb..4c66e966ef 100644
--- a/apps/ocsp.c
+++ b/apps/ocsp.c
@@ -451,7 +451,8 @@ int ocsp_main(int argc, char **argv)
if ((issuers = sk_X509_new_null()) == NULL)
goto end;
}
- sk_X509_push(issuers, issuer);
+ if (!sk_X509_push(issuers, issuer))
+ goto end;
break;
case OPT_CERT:
X509_free(cert);