summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDr. Stephen Henson <steve@openssl.org>2016-09-21 12:57:01 +0100
committerDr. Stephen Henson <steve@openssl.org>2016-09-21 19:56:05 +0100
commit709ec8b3848e2ac201b86f49c5561debb8572ccd (patch)
tree2ee0679012e0f24b044d53da36baefc5d2137e73
parent62841a2350f76a5207376d581acec319196447d7 (diff)
Remove unnecessary check.
The overflow check will never be triggered because the the n2l3 result is always less than 2^24. Reviewed-by: Matt Caswell <matt@openssl.org>
-rw-r--r--ssl/s3_both.c5
1 files changed, 0 insertions, 5 deletions
diff --git a/ssl/s3_both.c b/ssl/s3_both.c
index 4b636b0e9b..d53275fcf9 100644
--- a/ssl/s3_both.c
+++ b/ssl/s3_both.c
@@ -415,11 +415,6 @@ long ssl3_get_message(SSL *s, int st1, int stn, int mt, long max, int *ok)
SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
goto f_err;
}
- if (l > (INT_MAX - 4)) { /* BUF_MEM_grow takes an 'int' parameter */
- al = SSL_AD_ILLEGAL_PARAMETER;
- SSLerr(SSL_F_SSL3_GET_MESSAGE, SSL_R_EXCESSIVE_MESSAGE_SIZE);
- goto f_err;
- }
if (l && !BUF_MEM_grow_clean(s->init_buf, (int)l + 4)) {
SSLerr(SSL_F_SSL3_GET_MESSAGE, ERR_R_BUF_LIB);
goto err;