diff options
| author | Pauli <pauli@openssl.org> | 2022-06-17 11:02:52 +1000 |
|---|---|---|
| committer | Pauli <pauli@openssl.org> | 2022-07-01 16:36:21 +1000 |
| commit | 3ee2611677e7e9f90e270f3ee4f343c9d3d86835 (patch) | |
| tree | 212bfb4e44944a34dcf2a1828c7ccd202a32a527 | |
| parent | be54ad88a67d2fba3b4fd51bef0fe7db0c01b99a (diff) | |
Coverity: fix 1506297: negative returns
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18587)
| -rw-r--r-- | crypto/dsa/dsa_ameth.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/crypto/dsa/dsa_ameth.c b/crypto/dsa/dsa_ameth.c index 1da67485e8..482b9e1e0a 100644 --- a/crypto/dsa/dsa_ameth.c +++ b/crypto/dsa/dsa_ameth.c @@ -198,6 +198,11 @@ static int dsa_priv_encode(PKCS8_PRIV_KEY_INFO *p8, const EVP_PKEY *pkey) ASN1_STRING_clear_free(prkey); + if (dplen <= 0) { + ERR_raise(ERR_LIB_DSA, DSA_R_BN_ERROR); + goto err; + } + if (!PKCS8_pkey_set0(p8, OBJ_nid2obj(NID_dsa), 0, V_ASN1_SEQUENCE, params, dp, dplen)) { OPENSSL_clear_free(dp, dplen); |