diff options
author | Frederik Rietdijk <fridh@fridh.nl> | 2016-05-09 18:33:43 +0200 |
---|---|---|
committer | Frederik Rietdijk <fridh@fridh.nl> | 2016-05-09 18:33:43 +0200 |
commit | 3beda443bc1571ef1d73afe0b3a5463f89299c53 (patch) | |
tree | 948da2044609e9ef629e4b54e46c2508a6caa1de /pkgs/development/python-modules | |
parent | 3853d1e97fa1dde244d73cb5d6c48d110660412d (diff) |
Python: re-enable default testing
In 303e976 default testing of setuptools packages was accidentally
disabled.
Diffstat (limited to 'pkgs/development/python-modules')
-rw-r--r-- | pkgs/development/python-modules/generic/default.nix | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/pkgs/development/python-modules/generic/default.nix b/pkgs/development/python-modules/generic/default.nix index b8e1e8cad71b..a90b66a33757 100644 --- a/pkgs/development/python-modules/generic/default.nix +++ b/pkgs/development/python-modules/generic/default.nix @@ -93,11 +93,13 @@ let runHook postCheck ''; - # We run all tests after software has been installed since that is - # a common idiom in Python - # + # Python packages that are installed with setuptools + # are typically distributed with tests. + # With Python it's a common idiom to run the tests + # after the software has been installed. + # For backwards compatibility, let's use an alias - doInstallCheck = attrs.doCheck or false; + doInstallCheck = attrs.doCheck or true; } else throw "Unsupported format ${format}"; @@ -121,7 +123,7 @@ python.stdenv.mkDerivation (builtins.removeAttrs attrs ["disabled" "doCheck"] // runHook postConfigure ''; - # Python packages don't have a checkPhase, only a installCheckPhase + # Python packages don't have a checkPhase, only an installCheckPhase doCheck = false; installPhase = attrs.installPhase or '' |