summaryrefslogtreecommitdiffstats
path: root/pkgs/development/interpreters/python/pypy/default.nix
diff options
context:
space:
mode:
authorAndreas Rammhold <andreas@rammhold.de>2019-12-16 16:22:21 +0100
committerAndreas Rammhold <andreas@rammhold.de>2019-12-16 16:37:16 +0100
commite9f522eee13629bb39a30950d4db1493596778c4 (patch)
treef14b62b764472052c84395249510b87e63576009 /pkgs/development/interpreters/python/pypy/default.nix
parent3e046ee556190a833cb9583166b25193e8ee1f0c (diff)
python: remove _manylinux.py
This will turn manylinux support back on by default. PIP will now do runtime checks against the compatible glibc version to determine if the current interpreter is compatible with a given manylinux specification. However it will not check if any of the required libraries are present. The motivation here is that we want to support building python packages with wheels that require manylinux support. There is no real change for users of source builds as they are still buildings packages from source. The real noticeable(?) change is that impure usages (e.g. running `pip install package`) will install manylinux packages that previously refused to install. Previously we did claim that we were not compatible with manylinux and thus they wouldn't be installed at all. Now impure users will have basically the same situation as before: If you require some wheel only package it didn't work before and will not properly work now. Now the program will fail during runtime vs during installation time. I think it is a reasonable trade-off since it allows us to install manylinux packages with nix expressions and enables tools like poetry2nix. This should be a net win for users as it allows wheels, that we previously couldn't really support, to be used.
Diffstat (limited to 'pkgs/development/interpreters/python/pypy/default.nix')
-rw-r--r--pkgs/development/interpreters/python/pypy/default.nix3
1 files changed, 0 insertions, 3 deletions
diff --git a/pkgs/development/interpreters/python/pypy/default.nix b/pkgs/development/interpreters/python/pypy/default.nix
index 8154a87f667d..b220bfa0f934 100644
--- a/pkgs/development/interpreters/python/pypy/default.nix
+++ b/pkgs/development/interpreters/python/pypy/default.nix
@@ -137,9 +137,6 @@ in with passthru; stdenv.mkDerivation rec {
# verify cffi modules
$out/bin/${executable} -c ${if isPy3k then "'import tkinter;import sqlite3;import curses;import lzma'" else "'import Tkinter;import sqlite3;import curses'"}
- # Python on Nix is not manylinux1 compatible. https://github.com/NixOS/nixpkgs/issues/18484
- echo "manylinux1_compatible=False" >> $out/lib/${libPrefix}/_manylinux.py
-
# Include a sitecustomize.py file
cp ${../sitecustomize.py} $out/lib/${libPrefix}/${sitePackages}/sitecustomize.py
'';