summaryrefslogtreecommitdiffstats
path: root/pkgs/build-support/setup-hooks
diff options
context:
space:
mode:
authorEmery Hemingway <ehmry@posteo.net>2020-11-25 17:27:31 +0100
committerFrederik Rietdijk <freddyrietdijk@fridh.nl>2020-12-08 05:35:48 +0100
commite4d17dc558f61f8565df025fa46de7035c4a1d93 (patch)
tree76377cb39154bb91be0e9be56217f83cf7f83f79 /pkgs/build-support/setup-hooks
parent46b8c00d0dce394e8b13c2644ce13c1b7f705d88 (diff)
setup-hooks/strip: more robust stripping
Use "find -exec" to strip rather than "find … | xargs …". The former ensures that stripping is attempted for each file, whereas the latter will stop stripping at the first failure. Unstripped files can fool runtime dependency detection and bloat closure sizes.
Diffstat (limited to 'pkgs/build-support/setup-hooks')
-rw-r--r--pkgs/build-support/setup-hooks/strip.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/pkgs/build-support/setup-hooks/strip.sh b/pkgs/build-support/setup-hooks/strip.sh
index f5fa9378fd7e..a7cdfd1d2767 100644
--- a/pkgs/build-support/setup-hooks/strip.sh
+++ b/pkgs/build-support/setup-hooks/strip.sh
@@ -51,7 +51,7 @@ stripDirs() {
if [ -n "${dirs}" ]; then
header "stripping (with command $cmd and flags $stripFlags) in$dirs"
- find $dirs -type f -print0 | xargs -0 ${xargsFlags:--r} $cmd $commonStripFlags $stripFlags 2>/dev/null || true
+ find $dirs -type f -exec $cmd $commonStripFlags $stripFlags '{}' \; #
stopNest
fi
}