summaryrefslogtreecommitdiffstats
path: root/nixos
diff options
context:
space:
mode:
authorSarah Brofeldt <sarah@qtr.dk>2020-09-22 08:30:29 +0200
committerSarah Brofeldt <sarah@qtr.dk>2021-03-10 08:10:30 +0100
commitfd02940262ab3b263bc979f6e28c6ed74ed9b41c (patch)
tree7963faf8b050f1600bd0a2ef457bfea968af6f99 /nixos
parent08ef8270563ee69bde17e69be803d89d353cd905 (diff)
nixos/apache-kafka: Use version-matched jre
Diffstat (limited to 'nixos')
-rw-r--r--nixos/doc/manual/release-notes/rl-2105.xml15
-rw-r--r--nixos/modules/services/misc/apache-kafka.nix9
2 files changed, 23 insertions, 1 deletions
diff --git a/nixos/doc/manual/release-notes/rl-2105.xml b/nixos/doc/manual/release-notes/rl-2105.xml
index 9a1e6b6618df..e052632ecafd 100644
--- a/nixos/doc/manual/release-notes/rl-2105.xml
+++ b/nixos/doc/manual/release-notes/rl-2105.xml
@@ -562,6 +562,21 @@ self: super:
<xref linkend="opt-services.xserver.videoDrivers" /> no longer uses the deprecated <literal>cirrus</literal> and <literal>vesa</literal> device dependent X drivers by default. It also enables both <literal>amdgpu</literal> and <literal>nouveau</literal> drivers by default now.
</para>
</listitem>
+ <listitem>
+ <para>
+ The <package>apacheKafka</package> packages are now built with
+ version-matched JREs. Versions 2.6 and above, the ones that recommend it,
+ use jdk11, while versions below remain on jdk8. The NixOS service has
+ been adjusted to start the service using the same version as the package,
+ adjustable with the new
+ <link linkend="opt-services.apache-kafka.jre">services.apache-kafka.jre</link>
+ option. Furthermore, the default list of
+ <link linkend="opt-services.apache-kafka.jvmOptions">services.apache-kafka.jvmOptions</link>
+ have been removed. You should set your own according to the
+ <link xlink:href="https://kafka.apache.org/documentation/#java">upstream documentation</link>
+ for your Kafka version.
+ </para>
+ </listitem>
</itemizedlist>
</section>
diff --git a/nixos/modules/services/misc/apache-kafka.nix b/nixos/modules/services/misc/apache-kafka.nix
index c1644c8f3658..69dfadfe54e0 100644
--- a/nixos/modules/services/misc/apache-kafka.nix
+++ b/nixos/modules/services/misc/apache-kafka.nix
@@ -106,6 +106,13 @@ in {
type = types.package;
};
+ jre = mkOption {
+ description = "The JRE with which to run Kafka";
+ default = cfg.package.passthru.jre;
+ defaultText = "pkgs.apacheKafka.passthru.jre";
+ type = types.package;
+ };
+
};
config = mkIf cfg.enable {
@@ -126,7 +133,7 @@ in {
after = [ "network.target" ];
serviceConfig = {
ExecStart = ''
- ${pkgs.jre}/bin/java \
+ ${cfg.jre}/bin/java \
-cp "${cfg.package}/libs/*" \
-Dlog4j.configuration=file:${logConfig} \
${toString cfg.jvmOptions} \